Skip to content

Refactor RealEnvStore methods to use uv_os_getenv/setenv/unsetenv #27211

Closed
Closed
Refactor RealEnvStore methods to use uv_os_getenv/setenv/unsetenv#27211
Labels
c++Issues and PRs that require attention from people who are familiar with C++.good first issueIssues that are suitable for first-time contributors.osIssues and PRs related to the os subsystem.processIssues and PRs related to the process subsystem.

Description

@joyeecheung
joyeecheung
opened on Apr 13, 2019

From a glance I think the uv_os_* methods are adequate to replace our conditional switches in the RealEnvStore methods.

I think this is a good first issue if you are familiar with C++ and has some idea on how to use libuv methods, but you may need to read into the libuv implementation to make sure the refactor does not change the functionality.

Pointers:

node/src/node_env_var.cc

Line 71 in dfd7e99

const char* val = getenv(*key);

node/src/node_env_var.cc

Line 107 in dfd7e99

setenv(*key, *val, 1);

node/src/node_env_var.cc

Line 123 in dfd7e99

if (getenv(*key)) return 0;

node/src/node_env_var.cc

Line 146 in dfd7e99

unsetenv(*key);

docs:

http://docs.libuv.org/en/v1.x/misc.html?highlight=uv_os_getenv#c.uv_os_getenv
http://docs.libuv.org/en/v1.x/misc.html?highlight=uv_os_getenv#c.uv_os_setenv
http://docs.libuv.org/en/v1.x/misc.html?highlight=uv_os_getenv#c.uv_os_unsetenv

Activity

  1. joyeecheung
    added
    good first issueIssues that are suitable for first-time contributors.
    osIssues and PRs related to the os subsystem.
    processIssues and PRs related to the process subsystem.
    c++Issues and PRs that require attention from people who are familiar with C++.
    on Apr 13, 2019

  2. joyeecheung commented on Apr 13, 2019

    @joyeecheung
    joyeecheung
    on Apr 13, 2019
    MemberAuthor

    Prior work: #14641

    It seems easier to refactor uv_os_setenv and uv_os_unsetenv, uv_os_getenv is trickier due to how the buffer allocation is handled - the caller needs to retry when the allocated buffer is not large enough.

  3. devasci commented on Apr 15, 2019

    @devasci
    devasci
    on Apr 15, 2019
    Contributor

    Hi, It seems to be a good item for me as a first timer. I will work one this and will share the updates soon.

  4. devasci commented on Apr 19, 2019

    @devasci
    devasci
    on Apr 19, 2019
    Contributor

    Modified as Joyee Cheung suggested and tested by following contributors guide.

    Created pull request: #27310

  5. 19 remaining items

  6. addaleax
    added 10 commits that reference this issue on Aug 20, 2019

    src: modified RealEnvStore::Get method to use libuv functions

    1501433

    src: modified RealEnvStore methods to use libuv functions

    eef9b8b

    src: Modified src/node_env_var.cc as per Joyee Cheung’s review comments

    7db9f03

    src: Modified to use 2 space for indentation.

    6ae79f7

    src: refactor RealEnvStore methods - review comments fixing - 1

    0271ee1

    src: refactor RealEnvStore methods - review comments fixing - 2

    4d51c93

    src: refactor RealEnvStore methods - review comments fixing - 2a

    1d0aa6e

    src: refactor RealEnvStore methods - review comments fixing - 3

    b40d71e

    src: refactor RealEnvStore methods - Joyee Cheung’s review remarks fixed

    88fedfc

    src: handle windows hidden/read-only env keys in set/query methods

    614f357
  7. addaleax
    closed this as completedin b354d12on Sep 12, 2019
  8. targos
    added a commit that references this issue on Sep 20, 2019

    src: modified RealEnvStore methods to use libuv functions

    981ec7d
  9. BridgeAR
    added a commit that references this issue on Sep 25, 2019

    src: modified RealEnvStore methods to use libuv functions

    4a5ba60
  10. sjarmak
    added a commit that references this issue on Jul 27, 2026

    src: modified RealEnvStore methods to use libuv functions

    b354d12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c++Issues and PRs that require attention from people who are familiar with C++.good first issueIssues that are suitable for first-time contributors.osIssues and PRs related to the os subsystem.processIssues and PRs related to the process subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions