Skip to content

Bug: 'Eterm' → 'eterm' in getColorDepth #26077

Closed
Closed
Bug: 'Eterm' → 'eterm' in getColorDepth#26077
Labels
good first issueIssues that are suitable for first-time contributors.ttyIssues and PRs related to the tty subsystem.

Description

@sttk
sttk
opened on Feb 13, 2019

I found a bug of getColorDepth at this line.
Elements of TERM_ENVS should be lower case because they are compared with lower case of env.TERM.

Activity

  1. hiroppy
    added
    ttyIssues and PRs related to the tty subsystem.
    on Feb 13, 2019

  2. ofrobots commented on Feb 13, 2019

    @ofrobots
    ofrobots
    on Feb 13, 2019
    Contributor

    @sttk do you want to try opening a pull-request for this? You can find a contribution guide here.

  3. ofrobots
    added
    good first issueIssues that are suitable for first-time contributors.
    on Feb 13, 2019

  4. Dlewis89 commented on Feb 14, 2019

    @Dlewis89
    Dlewis89
    on Feb 14, 2019

    I would like to take a shot at this if sttk doesnt want too.

  5. sttk commented on Feb 14, 2019

    @sttk
    sttk
    on Feb 14, 2019
    Author

    @Dlewis89 OK. I ask you this pr.

  6. abshek
    added a commit that references this issue on Feb 15, 2019

    lib: converted element to lowercase in tty.js

    543fdfd
  7. danbev
    closed this as completedin 17820econ Feb 19, 2019
  8. addaleax
    added a commit that references this issue on Feb 19, 2019

    lib: converted element to lowercase in tty.js

    faa1f3d
  9. rvagg
    added a commit that references this issue on Feb 28, 2019

    lib: converted element to lowercase in tty.js

    bf61050
  10. sjarmak
    added a commit that references this issue on Jul 27, 2026

    lib: converted element to lowercase in tty.js

    17820ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueIssues that are suitable for first-time contributors.ttyIssues and PRs related to the tty subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions