Skip to content

build: use build_release target in vcbuild.bat to build releases #2516

Description

@rvagg

Currently Jenkins is doing this for iojs+release:

vcbuild.bat release msi %ARCH% upload

But 1f12e032 introduced the build_release target that was in joyent/node (also see nodejs/node-convergence-archive#27). We should be using that, perhaps:

vcbuild.bat build-release upload

Needs investigation to make sure it doesn't break stuff. It would seem right now that our Windows releases don't have Intl enabled because of this.

Activity

  1. self-assigned this
    on Aug 24, 2015
  2. added this to the 4.0.0 milestone on Aug 24, 2015
  3. added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Aug 24, 2015
  4. rvagg commented on Sep 4, 2015

    @rvagg
    MemberAuthor

    FYI this isn't holding up release ("A .bat file is holding up the whole thing!"—hackernews), it should be completed by recent commits to core, I'm leaving this open as a reminder to confirm that it's working as expected in the 4.0 RC builds.

  5. timdorr commented on Sep 4, 2015

    @timdorr

    Heh, that was me. Sorry about that. No drama intended :)

  6. Fishrock123 commented on Sep 8, 2015

    @Fishrock123
    Contributor

    @rvagg is this done now? It's marked off in the timeline.

  7. rvagg commented on Sep 8, 2015

    @rvagg
    MemberAuthor

    seems to be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

buildIssues and PRs related to Node.js builds or CI infrastructure.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions