Skip to content

AIX bug in Makefile - find with -not #24634

Closed
Closed
AIX bug in Makefile - find with -not#24634
Labels
aixIssues and PRs related to the AIX platform.buildIssues and PRs related to Node.js builds or CI infrastructure.

Description

@rvagg
rvagg
opened on Nov 25, 2018

Noticed this the other day when testing the proposed SKIP_XZ feature. Running make on AIX complains when running make now because there is a find with a -not which is apparently not supported. It was first introduced in eebcb48, which is a year ago. It's not fatal, but it errors when you start make and lint-md won't work properly because of it.

LINT_MD_MISC_FILES := $(shell find $(LINT_MD_TARGETS) -type f \
  -not -path '*node_modules*' -not -path 'test/fixtures/*' -name '*.md') \
  $(LINT_MD_ROOT_DOCS)

The error shows up in every run if you look at the console output, e.g. the latest one right now @ https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/19164/consoleFull:

15:41:59 + gmake run-ci -j 5
15:41:59 find: 0652-017 -not is not a valid option.
15:41:59 python ./configure --verbose  --dest-cpu=ppc64

Low priority I suppose. Over to the IBM folks.

Activity

  1. rvagg
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    aixIssues and PRs related to the AIX platform.
    on Nov 25, 2018

  2. rvagg commented on Nov 25, 2018

    @rvagg
    rvagg
    on Nov 25, 2018
    MemberAuthor

    @nodejs/platform-aix

  3. Trott commented on Nov 25, 2018

    @Trott
    Trott
    on Nov 25, 2018
    Member

    -not is a synonym for ! I believe, and that should be supported everywhere.

  4. Trott
    added a commit that references this issue on Nov 25, 2018

    build: replace `-not` with `!` in `find`

    5b91604

  5. Trott commented on Nov 25, 2018

    @Trott
    Trott
    on Nov 25, 2018
    Member

    Proposed fix in #24635

  6. gireeshpunathil
    closed this as completedin e20be47on Nov 25, 2018
  7. targos
    added a commit that references this issue on Nov 27, 2018

    build: replace `-not` with `!` in `find`

    059d9c7
  8. rvagg
    added a commit that references this issue on Nov 28, 2018

    build: replace `-not` with `!` in `find`

    3fa4def
  9. refack
    added a commit that references this issue on Jan 14, 2019

    build: replace `-not` with `!` in `find`

    edcc4e6
  10. BethGriggs
    added a commit that references this issue on Feb 11, 2019

    build: replace `-not` with `!` in `find`

    95a3b3e
  11. rvagg
    added a commit that references this issue on Feb 28, 2019

    build: replace `-not` with `!` in `find`

    748de6b
  12. sjarmak
    added a commit that references this issue on Jul 27, 2026

    build: replace `-not` with `!` in `find`

    e20be47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    aixIssues and PRs related to the AIX platform.buildIssues and PRs related to Node.js builds or CI infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions