Repository navigation
test-process-active-wraps fails on windows #246
Description
Activity
- added this to the milestone
on Jan 7, 2015 nodejs/node-v0.x-archive#8989 is a proposed fix.
@cjihrig Is there any motivation for that revert, other than just to make the test pass.
It's quite easy to make the test pass. Just do:
setTimeout(function() { setInterval(function() { ... do the check here ... }); }, 10);That gives the event loop enough time to clean up the TCPWrap object.
@piscisaureus yes, the revert was done to get everything back to passing. I originally tried adding a
setTimeout()of 5 seconds around thesetImmediate(). The test still failed - the server handle was cleaned up, but the timeout was lingering.The test does pass if I add a
setTimeout()AND asetImmediate()around the originalsetImmediate(), but that just seems so hacky.@cjihrig
If that (now reverted) patch made node better, put it back and fix the test in the hacky way.
The test is quite questionable - the _getActiveHandles() and _getActiveRequests() APIs are there for debugging only, node makes no guarantees about their contents. It just happens to be that Timer handles end up in that list and Immediate handles don't. And that on windows the TCPWrap might live a bit longer than on unix.- added a commit that references this issue
on Jan 8, 2015 Fixed in b5c9dcb
- added a commit that references this issue
on May 11, 2026
Tracked in node: nodejs/node-v0.x-archive#8986
According to @cjihrig:
The problem is likely due to the DNS resolution that's now needed, so net.js postpones TCPWrap creation, now doing it on the same loop turn in which the assertion is done.