Repository navigation
intl: Will Intl.Segmenter need full ICU in Node.js even for the 'en' locale? #24039
Description
Activity
cc @nodejs/v8 @nodejs/intl.
I'm a fan of anything that forces us to ship full icu
Reacted by Vse Mozhe ButyThe answer from the implementers:
Question: Will this need full ICU in Node.js even for the 'en' locale?
Answer: YESWell, this is a strong argument to ship full ICU by default.
Reacted by snekReacted by snekOur table is not correct anymore:
small-icuforIntlis not evenpartial (English-only)now.Well, this is a strong argument to ship full ICU by default.
As I mentioned in #21676, we should separate dev & test builds from release builds.
Turning on full-icu only for release builds has IMO the most benefit, while carries the least cost for the current dev & test workflow (and build infra overhead).
We could add some full-icu specific tests that will run only as part of the daily CI job./CC @nodejs/testing
Is there anything to do at this time other than be aware that This Is Coming?
Should this be closed for the time being? If not, what is the condition for closing?
what is the condition for closing?
Maybe clarification if this is wontfix from the ICU team?
@nodejs/intl Are we going to start shipping full icu? Or not? Or to be determined?
So,for this case, I'd think we would just change the definition of 'small icu' to include the break iterator files.
It's this line, to change
brkiterfromnoneto proabblylocales(meaning just 'en' by default) https://github.com/nodejs/node/blob/master/tools/icu/icu_small.json#L19So probably this issue should be closed with "no", or used to put the needed fix in once this v8 change lands.
Reacted by Vse Mozhe ButyWe're shipping full icu by default now so closing.
Reacted by Vse Mozhe ButyReacted by Steven Luscher
See tc39/proposal-intl-segmenter#50