Skip to content

Failing test on v10.x-staging #23633

Description

@richardlau

Refs: #23630 (comment)

It looks like there's a failing test on v10.x-staging due to a backport.

https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/6096/console

18:49:40 not ok 1661 parallel/test-stream-wrap-drain
18:49:40   ---
18:49:40   duration_ms: 0.87
18:49:40   severity: fail
18:49:40   exitcode: 1
18:49:40   stack: |-
18:49:40     /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-stream-wrap-drain.js:8
18:49:40     const { ShutdownWrap } = internalBinding('stream_wrap');
18:49:40                              ^
18:49:40     
18:49:40     TypeError: internalBinding is not a function
18:49:40         at Object.<anonymous> (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-stream-wrap-drain.js:8:26)
18:49:40         at Module._compile (internal/modules/cjs/loader.js:688:30)
18:49:40         at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
18:49:40         at Module.load (internal/modules/cjs/loader.js:598:32)
18:49:40         at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
18:49:40         at Function.Module._load (internal/modules/cjs/loader.js:529:3)
18:49:40         at Function.Module.runMain (internal/modules/cjs/loader.js:741:12)
18:49:40         at startup (internal/bootstrap/node.js:285:19)
18:49:40         at bootstrapNodeJSCore (internal/bootstrap/node.js:739:3)
18:49:40   ...

The failing test was added to v10.x-staging in 7af84fc.

It looks like lib/internal/test/binding.js differs between v10.x-staging and master:
v10.x-staging:
https://github.com/nodejs/node/blob/2d4d546bcb2a896b9771753f90e1dacb2e706d0b/lib/internal/test/binding.js#L1-L14

master:

'use strict';
process.emitWarning(
'These APIs are exposed only for testing and are not ' +
'tracked by any versioning system or deprecation process.',
'internal/test/binding');
module.exports = { internalBinding };

and it looks like this change is 9f5cc1f#diff-01901c3bbffdf0cd41374f4f2a02bdb8 which is from semver-major #22029.

cc @nodejs/releasers @nodejs/backporters

Activity

  1. added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Oct 13, 2018
  2. richardlau commented on Oct 13, 2018

    @richardlau
    MemberAuthor

    I think the fix is to change
    https://github.com/nodejs/node/blob/7af84fccb95aa9b1ad30d9327e20a303e8f3c58f/test/parallel/test-stream-wrap-drain.js#L7-L8

    to

    const { ShutdownWrap } = process.binding('stream_wrap'); 

    and remove
    https://github.com/nodejs/node/blob/7af84fccb95aa9b1ad30d9327e20a303e8f3c58f/test/parallel/test-stream-wrap-drain.js#L1

    but I'm unsure as I'm not currently on a build environment to test locally.

    What do we want to do -- PR ontop of the current v10.x-staging or back out 7af84fc and manually backport #23294?

  3. Trott commented on Oct 13, 2018

    @Trott
    Member

    @targos is reading over my shoulder and says: The solution is to back out the commit, cherry-pick the commit, and make the modification before pushing to the v10.x-staging.

  4. Trott commented on Oct 13, 2018

    @Trott
    Member

    Done. (@targos talked me through it.) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions