build: should win_delay_load_hook be removed? #23253

Activity

1. Fishrock123

   added

   buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.

   toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.

   questionIssues asking questions about Node.js.Issues asking questions about Node.js.

   on Oct 5, 2018
2. richardlau

   added

   addonsIssues and PRs related to native addons.Issues and PRs related to native addons.

   on Oct 13, 2018
3. richardlau commented on Oct 13, 2018

   

   richardlau

   on Oct 13, 2018

   Member

   More actions

   nodejs/node-gyp#1566 is extending win_delay_load_hook for electron, so it probably is still needed.
4. richardlau commented on Oct 13, 2018

   

   richardlau

   on Oct 13, 2018

   Member

   More actions

   cc @nodejs/node-gyp
5. refack commented on Oct 13, 2018

   

   refack

   on Oct 13, 2018

   Contributor

   More actions

   AFAIU it's needed for when the host executable is renamed. We do want precompiled binaries to be maximally compatible, so if this still fixes that scenario I'd say, keep it.
6. JCMais commented on Oct 17, 2018

   

   JCMais

   on Oct 17, 2018

   ContributorAuthor

   More actions

   Had forgot about Electron, looks like it's still required then, and will stay that way. I think we can close this issue.
7. richardlau

   closed this as completedon Oct 17, 2018