Skip to content

url.format prefers host over hostname, but http.request does the opposite #2277

Closed
Closed
url.format prefers host over hostname, but http.request does the opposite#2277
Labels
httpIssues and PRs related to the http subsystem.semver-majorPRs that contain breaking changes and should be released in the next major version.stalledIssues and PRs manually marked as stalled and scheduled for automatic closure.urlIssues and PRs related to the legacy built-in url module.

Description

@nfriedly
nfriedly
opened on Jul 30, 2015

I noticed this when working on #2271 - regardless of which one you think should "win", you'd expect the last two lines here to end up with the same url:

var myUrl = url.parse('http://foo.com/');
myUrl.host = 'bar.com';
url.format(myUrl); // => 'http://bar.com/'
http.get(myUrl); // makes a request to http://foo.com/

To node/io.js's credit, they are both documented correctly, but that only goes so far.

I don't really care which one wins (I suppose I'd pick hostname if I had to choose), but I think we should consider making a breaking change at some point in order to make those two APIs more consistent.

(Getters and setters on Url objects would help, but I could imagine someone doing this to a regular Object as well, so I still think the APIs should be consistent.)

Activity

  1. Fishrock123
    added
    httpIssues and PRs related to the http subsystem.
    urlIssues and PRs related to the legacy built-in url module.
    on Jul 30, 2015

  2. Fishrock123 commented on Jul 30, 2015

    @Fishrock123
    Fishrock123
    on Jul 30, 2015
    Contributor

    (Getters and setters on Url objects would help, but I could imagine someone doing this to a regular Object as well, so I still think the APIs should be consistent.)

    See #1591 and related (reverts of changes originally introduced in #1561) for why this will take an extended period of time to change to.

  3. nfriedly commented on Jul 30, 2015

    @nfriedly
    nfriedly
    on Jul 30, 2015
    ContributorAuthor

    Yea, I looked at #1591 and decided that this was an different enough issue to merit it's own ticket.

  4. Trott
    added
    semver-majorPRs that contain breaking changes and should be released in the next major version.
    on Mar 11, 2016
  5. jasnell
    added
    stalledIssues and PRs manually marked as stalled and scheduled for automatic closure.
    on Apr 9, 2016

  6. jasnell commented on Mar 24, 2017

    @jasnell
    jasnell
    on Mar 24, 2017
    Member

    this is unlikely to change in the current url module implementation due to backwards compat concerns. Closing

  7. jasnell
    closed this as completedon Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    httpIssues and PRs related to the http subsystem.semver-majorPRs that contain breaking changes and should be released in the next major version.stalledIssues and PRs manually marked as stalled and scheduled for automatic closure.urlIssues and PRs related to the legacy built-in url module.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions