Repository navigation
Assertion Error on v8.11.4 (macOS 10.13) #22570
Description
- Version: v8.11.4
- Platform: Darwin irtdev01x 17.7.0 Darwin Kernel Version 17.7.0: Thu Jun 21 22:53:14 PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64 x86_64
- Subsystem:
I'm not 100% sure what the cause of the isssue is here so any help would be appreciated!
node[55901]: ../src/process_wrap.cc:167:static void node::(anonymous namespace)::ProcessWrap::Spawn(const FunctionCallbackInfo<v8::Value> &): Assertion `gid_v->IsInt32()' failed.
1: node::Abort() [/Users/jenkins/.nvs/node/8.11.4/x64/bin/node]
2: node::(anonymous namespace)::DomainEnter(node::Environment*, v8::Local<v8::Object>) [/Users/jenkins/.nvs/node/8.11.4/x64/bin/node]
3: node::(anonymous namespace)::ProcessWrap::Spawn(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/jenkins/.nvs/node/8.11.4/x64/bin/node]
4: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) [/Users/jenkins/.nvs/node/8.11.4/x64/bin/node]
5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/Users/jenkins/.nvs/node/8.11.4/x64/bin/node]
6: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/Users/jenkins/.nvs/node/8.11.4/x64/bin/node]
7: 0x3030c1b042fdSteps to recreate:
npm install -g citgm
citgm <any_module>
Activity
addaleax commentedon Aug 28, 2018
I can’t reproduce this locally, but …
child_process.spawn('node', {gid: (2**20)**2})does the trick, even onmaster, because we check only thatgidis an integer in JS, when we really should check that it’s an Int32 (and there’s a chance of it being a getter, which I think we also don’t account for).child_process: fix handling of incorrect uid/gid in spawn
gdams commentedon Aug 29, 2018
FYI the gid on this mac was as follows:
changing it from
4294967295(nogroup)to20(staff)has fixed things on my endchild_process: fix handling of incorrect uid/gid in spawn
child_process: fix handling of incorrect uid/gid in spawn
child_process: fix handling of incorrect uid/gid in spawn
child_process: fix handling of incorrect uid/gid in spawn
apapirovski commentedon Oct 18, 2018
This got fixed.