Repository navigation
Add a proccess module to the common library #22303
Description
Activity
Tests are the one place where it doesn't always make sense to keep could DRY. (See https://stackoverflow.com/q/6453235/436641 for example.) And this function is tiny. Abstracting it out does not gain us much. It appears in three tests.
I wouldn't stop it if someone wanted to do it, but I wouldn't bother.
Reacted by Gabi(Actually, I probably would stop it. The test
commonmodule is a monolith that needs fewer things in it, not more.)Reacted by GabiMakes sense, I will close the issue. Thanks again!
Describe the solution you'd like
I've been reading the Testing for internet and I've seen the function
killChildrenrepeatedly defined over many files, such astest/internet/test-dgram-multicast-set-interface-lo.jsandtest/internet/test-dgram-broadcast-multi-process.js, and other similar patternsDescribe alternatives you've considered
I was wondering if it was a good idea to add a process module inside the common library so to not repeat code inside the tests. Otherwise we could add a
Utilslibrary.Thanks!