Skip to content

AssertionError at TLSWrap.onhandshakestart (_tls_wrap.js:66:3) #22240

Description

@alexlamsl
  • Version: v10.6.0
  • Platform: Windows 10 x64
  • Subsystem: tls

A simple HTTPS server will occasionally die with the following trace:

assert.js:269
    throw err;
    ^

AssertionError [ERR_ASSERTION]: false == true
    at TLSWrap.onhandshakestart (_tls_wrap.js:66:3)
    at TLSWrap.loadSession [as onclienthello] (_tls_wrap.js:127:19)

The only relevant detail I can think of is the system clock is configured to synchronise with ntp.pool.org

Activity

  1. alexlamsl commented on Aug 10, 2018

    @alexlamsl
    Author

    IIRC I have observed that once on 10.4.1 back then, which prompted me to upgrade to 10.6.0

  2. maclover7 commented on Aug 10, 2018

    @maclover7
    Contributor

    @alexlamsl Would you be able to please provide a minimal Node.js application to reproduce the problem

  3. added
    tlsIssues and PRs related to the tls subsystem.
    on Aug 10, 2018
  4. alexlamsl commented on Aug 10, 2018

    @alexlamsl
    Author

    @maclover7 crashing only 4 times over ~2 months makes investigations rather difficult.

    If/when I have a reliable test case to illustrate this issue, you'll be the first to know.

  5. alexlamsl commented on Aug 10, 2018

    @alexlamsl
    Author

    FWIW this is the line that aborts node.exe:

    assert(now >= lastHandshakeTime);

  6. n1k1t commented on Aug 12, 2018

    @n1k1t

    Same problem. Node v10.5.0

  7. meesha81 commented on Aug 14, 2018

    @meesha81

    Same here, node v10.5.0
    Aug 14 13:09:07: assert.js:269
    Aug 14 13:09:07: throw err;
    Aug 14 13:09:07: ^
    Aug 14 13:09:07: AssertionError [ERR_ASSERTION]: false == true
    Aug 14 13:09:07: at TLSWrap.onhandshakestart (_tls_wrap.js:66:3)

  8. adabru commented on Aug 19, 2018

    @adabru

    I'm getting exactly the same 5 lines of error. It seems to occur after my ssl cert is renewed and the https server is auto-closed then recreated with the new cert+key. @alexlamsl maybe simulating a certificate change will trigger the error? If it's complex for you to try, I could try it out.

  9. alexlamsl commented on Aug 20, 2018

    @alexlamsl
    Author

    @adabru go right ahead — in my case the certificate always static.

  10. adabru commented on Aug 20, 2018

    @adabru

    Ok, I couldn't reproduce it with changing the certificate.

  11. calzoneman commented on Aug 21, 2018

    @calzoneman

    Potentially related to issue #22149 / PR #22214.

    I also ran into this issue, and subtracting the date from when the process started to when I got the first assertion error was almost exactly 2^31 milliseconds. And from tracing back through the code that leads to this assertion failure, it depends on the same GetNow() that was fixed in that PR.

  12. alexlamsl commented on Aug 21, 2018

    @alexlamsl
    Author

    @calzoneman thanks for the heads up - will test on 10.9.0 for a while & report back.

  13. adabru commented on Aug 22, 2018

    @adabru

    In my case it also were 2^31 milliseconds.

  14. nesc58 commented on Aug 27, 2018

    @nesc58

    Same error here with node 10.6.0

  15. nianjie commented on Sep 24, 2018

    @nianjie

    same error here with node 10.0.0

  16. uplg commented on Sep 24, 2018

    @uplg

    Same error with Node 10 on a Raspberry Pi running Docker (node:latest)

    Can't find any step to reproduce

  17. Trott commented on Nov 23, 2018

    @Trott
    Member

    Potentially related to issue #22149 / PR #22214.

    That fix landed in 10.9.0, so that's consistent with people who have reported this since to all be running releases earlier than that. Any chance anyone updated to 10.9.0 or later and noticed the problem stopping?

  18. calzoneman commented on Nov 23, 2018

    @calzoneman

    @Trott yes, the problem does not occur in node >= 10.9.0

  19. Trott commented on Nov 24, 2018

    @Trott
    Member

    Great! I'll close this. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tlsIssues and PRs related to the tls subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions