Repository navigation
UNREACHABLE in WorkerThreadsTaskRunner::PostDelayedTask #22157
Description
Activity
- changed the title
[-]UNREACHABLE in NodePlatform::CallDelayedOnWorkerThread[/-][+]UNREACHABLE in WorkerThreadsTaskRunner::PostDelayedTask[/+]on Aug 6, 2018 would this diff work? its sorta copied from the foreground runner's PostDelayedTask
diff --git a/src/node_platform.cc b/src/node_platform.cc index 6a3ae2e5dc..c41e6624e8 100644 --- a/src/node_platform.cc +++ b/src/node_platform.cc @@ -46,7 +46,15 @@ void WorkerThreadsTaskRunner::PostTask(std::unique_ptr<Task> task) { void WorkerThreadsTaskRunner::PostDelayedTask(std::unique_ptr<v8::Task> task, double delay_in_seconds) { - UNREACHABLE(); + uv_timer_t timer; + timer.data = std::move(task).get(); + uint64_t delay_millis = static_cast<uint64_t>(delay_in_seconds + 0.5) * 1000; + uv_timer_init(uv_default_loop(), &timer); + uv_timer_start(&timer, [](uv_timer_t* timer) { + auto task = reinterpret_cast<v8::Task*>(timer->data); + task->Run(); + }, delay_millis, 0); + uv_unref(reinterpret_cast<uv_handle_t*>(&timer)); } void WorkerThreadsTaskRunner::BlockingDrain() {
I think I’m working on enough things for now, but if somebody wants to take this and feels up for it, I’m happy to support as needed
- added a commit that references this issue
on Aug 28, 2018 - added 2 commits that reference this issue
on Sep 3, 2018 - added a commit that references this issue
on Nov 3, 2018 - added a commit that references this issue
on Jul 27, 2026
v8_inspector::V8InspectorImpl::EvaluateScope::setTimeoutcallsNodePlatform::CallDelayedOnWorkerThreadwhich callsWorkerThreadsTaskRunner::PostDelayedTaskwhich hasUNREACHABLE().any calls to
Runtime.evaluatewith a timeout will therefore abort the process.../cc @addaleax @TimothyGu