Node 10: http response.close is always triggered

Version: Node 10.3.0
Platform: Linux 4.16.11
Subsystem: http

index.js:

const http = require('http');

http.createServer((req, res) => {
  res.writeHead(200);
  
  res.on('finish', () => {
    console.log('finish');
  });

  res.on('close', () => {
    console.log('close');
  });
  
  res.end();

}).listen(3000);

$ nvm use 10; node index.js
Now using node v10.3.0 (npm v6.1.0) # run curl localhost:3000 now
finish
close
^C
$ nvm use 8; node index.js
Now using node v8.9.4 (npm v5.6.0) # run curl localhost:3000 now
finish
^C
$

According to the docs res.close should only be called if res.end is not. Unfortunately there doesn't seem to be an event emitted for res.end so I could not check to see whether or not it was triggered.

However, as is visible in the example above:

Node 8
- finish event triggered
- close event not triggered,
Node 10
- finish event triggered
- close event triggered

Related: #21047
Ref: #20611

If I understand correctly, #21047 implies that res.close always being called is now considered the correct behavior?

@nodejs/http Anything to do here?

Fix issue with `close` event always being emitted

We are in the process of reverting the change in #21809

Bump node-pre-gyp version

Sounds like there's nothing left to address here. The change was reverted.

we are seeing this issue on Node V12.13.x.

@Srinivas-Vemula

@Srinivas-Vemula That's expected as the change was kept in master, it was only reverted for v10.x.

Fix issue with `close` event always being emitted

Navigation Menu

Repository navigation

Node 10: http response.close is always triggered #21063

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Node 10: http response.close is always triggered #21063

Description

Activity

mscdex commented on May 31, 2018

msmol commented on May 31, 2018

addaleax commented on Jul 26, 2018

targos commented on Jul 26, 2018

apapirovski commented on Oct 18, 2018

Srinivas-Vemula commented on Jan 17, 2020

mscdex commented on Jan 17, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions