Skip to content

Repl eval() with context ignored in 10.2.0+ #20965

Closed
Closed
Repl eval() with context ignored in 10.2.0+#20965
Labels
regressionIssues related to regressions.replIssues and PRs related to the REPL subsystem.

Description

@jdalton
jdalton
opened on May 25, 2018

The commit here 9aa4ec4 has caused default repl#eval to ignore the context parameter passed to it. The issue was introduced in PR #20617 (issue #19021).

Activity

  1. addaleax
    added
    replIssues and PRs related to the REPL subsystem.
    regressionIssues related to regressions.
    on May 25, 2018

  2. addaleax commented on May 25, 2018

    @addaleax
    addaleax
    on May 25, 2018
    Member

    I’d just revert the patch for now. Thoughts?

  3. jdalton commented on May 25, 2018

    @jdalton
    jdalton
    on May 25, 2018
    MemberAuthor

    IMO since the bit reverted would be just extra hints a revert would be ok.
    Then it could be retooled and merged at a later time.

  4. cjihrig
    added a commit that references this issue on May 28, 2018

    Revert "repl: add friendly tips about how to exit repl"

    4dbfb09
  5. cjihrig
    closed this as completedin #20972on May 28, 2018

  6. jdalton commented on May 28, 2018

    @jdalton
    jdalton
    on May 28, 2018
    MemberAuthor

    Thank you @cjihrig!

  7. MylesBorins
    added a commit that references this issue on May 29, 2018

    Revert "repl: add friendly tips about how to exit repl"

    5f9c01b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    regressionIssues related to regressions.replIssues and PRs related to the REPL subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions