Skip to content

Inconsistent styling of deprecated items #20841

Description

@mscdex
  • Version: master
  • Platform: n/a
  • Subsystem: doc

There are some places in the documentation where deprecated items are not especially highlighted/styled as being deprecated, whereas others have both the red 'deprecated' label in the outline at the top of the page and the big red bar in the actual description. This is the case, no matter what level of deprecation is involved (doc-only, runtime, etc.).

For example: crypto.DEFAULT_ENCODING and crypto.fips are both deprecated, but are not highlighted as such, unlike crypto.createCipher which is.

There may be other instances of this throughout all of the documentation, but these are the first ones I noticed.

Activity

  1. added
    docIssues and PRs related to Node.js documentation.
    on May 20, 2018
  2. Trott commented on May 21, 2018

    @Trott
    Member

    @nodejs/documentation @nodejs/website

  3. ryzokuken commented on May 21, 2018

    @ryzokuken
    Contributor

    I think we should add the red bars and red labels wherever we missed to add them, but would love to get @vsemozhetbyt's thoughts on this.

  4. vsemozhetbyt commented on May 21, 2018

    @vsemozhetbyt
    Contributor

    Red labels in TOCs are added automatically by the doc script. To get red bars we just need this blockquote element straight after a heading or a YAML block (if it is present):

    > Stability: 0 - Deprecated[: More info if needed.]
  5. vsemozhetbyt commented on May 21, 2018

    @vsemozhetbyt
    Contributor

    As for where they should be added, maybe we need to check deprecations.md against all other docs + maybe to grep "deprecated" in all docs. Not sure, but maybe this is appropriate for the first good issues or Code-and-learn sessions?

  6. ryzokuken commented on May 21, 2018

    @ryzokuken
    Contributor

    @Trott maybe we could use a few of these for https://www.nodetodo.org/?

  7. Trott commented on May 21, 2018

    @Trott
    Member

    @Trott maybe we could use a few of these for https://www.nodetodo.org/?

    Sure! (Although I bet they will be grabbed faster if you open an issue for each one and label it good first contribution.)

  8. ryzokuken commented on May 21, 2018

    @ryzokuken
    Contributor

    Sure, I'll make a few.

  9. jasnell commented on Aug 12, 2018

    @jasnell
    Member

    should this remain open?

  10. added a commit that references this issue on Oct 19, 2018
  11. added a commit that references this issue on Oct 20, 2018
  12. added a commit that references this issue on Oct 21, 2018
  13. added a commit that references this issue on Nov 28, 2018
  14. added a commit that references this issue on Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    deprecationsIssues and PRs related to deprecations.docIssues and PRs related to Node.js documentation.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions