Repository navigation
ReadableAsyncIterator error not handled #20347
Description
- Version: https://github.com/nodejs/node, master (No version, straight from source)
- Platform: -
- Subsystem: -
It appears that this[kError] could never be anything other than null, as in onError, iter.error = is used rather than iter[kError] = , this means in next, this[kError] will always be null, and the error will always be sitting there.
It looks like that if the error occurs while waiting for the next read it will invoke this[kLastReject], at any other point it will go unnoticed.
I can't see anywhere iter.error is used, which is why I am making this issue
If I'm misdirected in what I am seeing, please do correct me 😀
Relevant link: https://github.com/nodejs/node/blob/master/lib/internal/streams/async_iterator.js#L61
Activity
[-]ReadableAsyncIterator error`[/-][+]ReadableAsyncIterator error not handled[/+]ryzokuken commentedon Apr 27, 2018
/cc @nodejs/streams @mcollina
mcollina commentedon Apr 27, 2018
There is already a fix for this: #20329.
It will likely go out on one of the next releases.
fabiancook commentedon Apr 30, 2018
Closed by PR #20329