Repository navigation
node 10 test release: util.inspect causing more issues #20180
Description
Activity
Is there some kind of reproduction? I’m not sure how much one would be able to tell just from looking at the source code…
@addaleax sorry i don't have a lot of info. yeah this was kinda meant to be a reproduction since iirc the only other place it happened was inside npm internals. but also i just wanted to make people aware that the change to util.inspect still appears to be in v10 builds
Was not the #20089 included in v10.0.0-test72549aa9cd?
if it was included then there's another bug here...
here's the screenshot they sent me
Oops. I can still reproduce the #19405 with https://nodejs.org/download/test/v10.0.0-test72549aa9cd/
Either the revert was not successful, or there is another cause.
cc @jasnell
Quick test on Windows:
node.v10.0.0-test72549aa9cd.exe "c:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" install eslint@4.18.2 node.v10.0.0-test72549aa9cd.exe "c:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" update
~5 min hanging with 100% CPU and 1.5 GB memory, I did not wait longer.
I think it’s just an oversight in the test build name – the referenced commit, 72549aa, is on
master, notv10.x-staging, and we didn’t land the revert on master (yet). We should probably change the test build name tov11.0.0-testXnow?Reacted by Vse Mozhe Buty, Aura, Rich Trott and Jaczhttps://nodejs.org/download/rc/v10.0.0-rc.1/ is OK.
@devsnek Could the discord.js issue be checked with this last RC?
I've just tested on rc.1, worked fine.
Reacted by Vse Mozhe ButySeems like this can be closed (although maybe we should open an issue for bumping the nightly name to
v11.0.0-testXbut I'm not even sure where those are downloaded from TBH). Feel free to comment or re-open if you disagree.
build: v10.0.0-test72549aa9cd
someone using discord.js pinged me about console.log hanging their process with the "Message" object. i assume this is related to brigear's change but its affecting the test build and moar data so i thought i would bring it up.
for debugging purposes the class is here: https://github.com/discordjs/discord.js/blob/master/src/structures/Message.js
once instantiated it is fairly deep and has a lot of circulars
/cc @BridgeAR @nodejs/util