Repository navigation
Merge commits on master #19854
Description
Activity
IMO it should be fixed. This wouldn't be the first time we break the 10 min rule.
Reacted by Anna Henningsen, Gibson Fahnestock and snek@nodejs/tsc ... how do we want to handle this? We should likely do a revert of those commits at this point. I would say that it's too late to force push.
Possible ref: #19471
- SGTM, let’s do it asap Il giorno ven 6 apr 2018 alle 18:37 Anatoli Papirovski < notifications@github.com> ha scritto:…IMO it should be fixed. This wouldn't be the first time we break the 10 min rule. — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#19854 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADL49Vcukpvr2-3zZdWrXtTe1FRz3_tks5tl5nMgaJpZM4TKXCc> .Reacted by Anna Henningsen, Michaël Zasso, Evan Lucas and Ruben Bridgewater
I'm fine with a force push if other @nodejs/tsc are.
+1 on force pushing. Otherwise we have a weird commit history.
+1 on force push
+1
Reacted by Myles BorinsAs an aside I've sent a feature request to github about finding a way to block merge commits from landing on branches
+1 as well,
I've force-pushed, removing the relevant commits.
Reacted by Rich Trottref: #19471 (comment)
There are two merge commits on master:
I don't know exactly when they were pushed and if it's something that we need to absolutely fix, but something else already landed on top of those.
/cc @nodejs/tsc @gireeshpunathil