test: Incorrect assumptions on the user uid and gid #19371

Activity

1. gireeshpunathil

   added

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   on Mar 15, 2018
2. bnoordhuis commented on Mar 19, 2018

   

   bnoordhuis

   on Mar 19, 2018

   Member

   More actions

   @gireeshpunathil Links to branches (master) aren't stable. Use links to tags or commits.

   Pro tip: if you go to https://github.com/nodejs/node/blob/master/test/parallel/test-child-process-spawnsync-validation-errors.js#L14 and press y, it turns the URL into a commit link.

   👍React with 👍1Reacted by Gireesh Punathil
3. gireeshpunathil

   added

   good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.

   on Mar 20, 2018
4. garwahl commented on Mar 22, 2018

   

   garwahl

   on Mar 22, 2018

   Contributor

   More actions

   @gireeshpunathil How would I begin working on this? Could you elaborate on what needs to be done
5. gireeshpunathil commented on Mar 22, 2018

   

   gireeshpunathil

   on Mar 22, 2018

   MemberAuthor

   More actions

   @garwahl -

   this line has the number of expected errors statically determined to be 62. This is based on the assumption of the condition at here and here will be true. When ran as root or ran in certain Containers, this may not be the case.

   So:

   1. Count the # of invalidArgTypeError that comes under these two sections separately.
   2. Define 1 variabales, assign 62 to that
   3. if not windows && process.getuid() === 0, reduce the count of invalidArgTypeError coming from that block, from the variable: 10
   4. if not windows && process.getgid() === 0, reduce the count further accordingly.
   5. apply the variable in place of 62.
   6. Add one liner comment against each of your changes so that someone does not stumble on the same issue in future.
   7. test in windows, non-windows, container & non-container environments if possible.

   Hope this helps!
6. garwahl commented on Mar 22, 2018

   

   garwahl

   on Mar 22, 2018

   Contributor

   More actions

   Thanks, I'll make a start and let you know if I run into any issues.

   👍React with 👍1Reacted by Gireesh Punathil
7. garwahl

   added a commit that references this issue on Mar 23, 2018

   test: fix incorrect assumptions on the user uid and gid

   ...

   e53a537
8. garwahl commented on Mar 27, 2018

   

   garwahl

   on Mar 27, 2018

   Contributor

   More actions

   @gireeshpunathil Please review PR when free, thanks
9. gireeshpunathil

   closed this as completedin 42c7402on Mar 29, 2018
10. sjarmak

    added a commit that references this issue on Jul 27, 2026

    test: fix incorrect assumptions on uid and gid

    ...

    42c7402