child_process: confusing error message from functions with empty string argument

Version: master (10.0.0)
Platform: Windows 7 x64
Subsystem: child_process

All these function calls produce a bit confusing error message:

child_process.execFile('');
child_process.exec('');
child_process.spawn('');

child_process.execFileSync('');
child_process.execSync('');
child_process.spawnSync('');

TypeError [ERR_INVALID_ARG_TYPE]: The "file" argument must be of type string. Received type string
    at normalizeSpawnArguments (child_process.js:389:11)
    ...

Compare with previous versions:

v4–v6: TypeError: Bad argument
v8–v9: TypeError: "file" argument must be a non-empty string

See

node/lib/child_process.js

Lines 388 to 389 in 74ff743

    
           if (typeof file !== 'string' || file.length === 0) 
        
             throw new ERR_INVALID_ARG_TYPE('file', 'string', file);

child_process: better spawn error message

I have this now

> TypeError [ERR_INVALID_ARG_TYPE]: The "file" argument must be of type string. Received type object
    at validateString (internal/validators.js:125:11)
    at normalizeSpawnArguments (child_process.js:414:3)
    at spawnSync (child_process.js:576:16)
    at execSync (child_process.js:669:13)

The same with exec()

Node v 11.10.1

UPD. ok, my bad, command was coming from async function and was wrapped in Promise.
The error The "file" argument must be of type string. Received type object might be more descriptive. 😉

child_process: better spawn error message

Navigation Menu

Repository navigation

child_process: confusing error message from functions with empty string argument #19235

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (typeof file !== 'string' \|\| file.length === 0)
	throw new ERR_INVALID_ARG_TYPE('file', 'string', file);

child_process: confusing error message from functions with empty string argument #19235

Description

Activity

seyfer commented on Nov 30, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions