Repository navigation
Change "comma-dangle" rule #19131
Description
What about changing this rule in eslint config? At the moment it's only-multiline which allows but does not require trailing commas, and it can create misunderstandings in code review process.
Besides, changing this rule to always-multiline will allow us to avoid misunderstandings and make diffs cleaner
Activity
apapirovski commentedon Mar 4, 2018
There would be too much churn, I think. Also, off the top of my head I'm not even certain how far back V8 support for it goes. Would we be able to backport such a change to v6.x?
daynin commentedon Mar 4, 2018
Ok, if we can't use
always-multilinefor some reason, let's useneverinsteadonly-multiline. I think it'll be much betterapapirovski commentedon Mar 4, 2018
There's going to be churn either way. Long-term we would likely prefer
always-multiline, it just might need to be a more gradual transition.Then again, if V6.x already supports trailing commas then if someone wanted to do that and immediately backport to all active release lines, I wouldn't personally stand in the way.
daynin commentedon Mar 4, 2018
@apapirovski v6 does not support trailing commas in function declarations and calls
daynin commentedon Mar 4, 2018
So, we can use this rule for objects and arrays only
daynin commentedon Mar 4, 2018
@apapirovski
I can change the rule and fix all errors but
How can I do this?
tniessen commentedon Mar 5, 2018
Not sure whether there is consensus about this, I myself am certainly not a fan of dangling commas and definitely not in favor of enforcing them. There are not too many situations where this rule actually reduces the diff size and it appears unnatural to me to end a list with a separator.
daynin commentedon Mar 5, 2018
I am going to close this issue due to the concerns in this PR #19133. Thank you for the discussion!