Skip to content

Improve md-lint by forbidding you #19030

Description

@BridgeAR

In our docs we try not to use you. If I remember correct, the md-linter actually has a possibility to add specific words to a black list. We might just add those in there as well to make sure they to not get back in.
The rule should only apply to ./docs/api/ *.md.

Some times it is just slipping through and we do not have to check for those explicitly anymore. What do others think?

Activity

  1. added
    metaIssues and PRs related to the general management of the project.
    on Feb 27, 2018
  2. mmarchini commented on Feb 27, 2018

    @mmarchini
    Contributor

    +1

  3. jasnell commented on Feb 27, 2018

    @jasnell
    Member

    Not just you, but first and second person (and third person singular) pronouns in general.

  4. BridgeAR commented on Feb 27, 2018

    @BridgeAR
    MemberAuthor

    @jasnell the issue with other pronouns is that they can also be used in a different context. And most pronouns were never used but we can definitely prohibit them as well.

  5. jasnell commented on Feb 27, 2018

    @jasnell
    Member

    There are some exceptions to the rule, for sure. For instance, third person plural and third person genderless pronouns (e.g. they, them, etc) are generally always ok.

  6. fhinkel commented on Feb 28, 2018

    @fhinkel
    Contributor

    +1 to linting for you, he, she, his, and her.

  7. cjihrig commented on Feb 28, 2018

    @cjihrig
    Contributor

    Probably we and our as well.

  8. Trott commented on Mar 7, 2018

    @Trott
    Member

    I'm not sure how I feel about this. Our style guide says to avoid personal pronouns but stops well short of prohibiting them. By making it a lint rule, it implies that they are prohibited.

    I guess the important question that is difficult to answer is: Is this likely to result in improved documentation?

  9. BridgeAR commented on Mar 7, 2018

    @BridgeAR
    MemberAuthor

    I personally do not have such an issue with you but it makes it easier for me as I tend to use it. With a lint rule I do not have to think about it anymore. And as far as I can tell that would probably not only be good for me but also for others. you is a common review comment in documentation PRs.

    If the documentation is improved when not using it? I am not sure... I have no strong opinion and do not want to weight in.

  10. apapirovski commented on Oct 26, 2018

    @apapirovski
    Contributor

    Going to close this out given the lack of progress. Feel free to reopen if you feel strongly about it but this is probably better done as a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    metaIssues and PRs related to the general management of the project.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions