Skip to content

lib: bootstrap should not have RegExp side effects #18930

Description

@bnoordhuis
$ ./out/Release/node -p 'RegExp.$_' | head -10
{ 'target_defaults': { 'cflags': [],
                       'default_configuration': 'Release',
                       'defines': [],
                       'include_dirs': [],
                       'libraries': []},
  'variables': { 'asan': 0,
                 'coverage': 'false',
                 'debug_http2': 'false',
                 'debug_nghttp2': 'false',
                 'force_dynamic_crt': 0,

(Due to fixing up config.gypi in setupConfig() in lib/internal/process.js.)

Activity

  1. added
    lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.
    on Feb 22, 2018
  2. gireeshpunathil commented on Mar 29, 2018

    @gireeshpunathil
    Member

    @bnoordhuis - close-able as #19140 has landed?

  3. bnoordhuis commented on Mar 29, 2018

    @bnoordhuis
    MemberAuthor

    Yep, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions