Skip to content

Flaky test-net-connect-local-error #18658

Description

@BridgeAR

https://ci.nodejs.org/job/node-test-commit-freebsd/15207/nodes=freebsd11-x64/console

not ok 2100 sequential/test-net-connect-local-error
  ---
  duration_ms: 0.233
  severity: fail
  stack: |-
    assert.js:74
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: undefined strictEqual 12347
        at Socket.onError (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/sequential/test-net-connect-local-error.js:18:10)
        at Socket.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/common/index.js:475:15)
        at Socket.emit (events.js:131:13)
        at emitErrorNT (internal/streams/destroy.js:64:8)
        at process._tickCallback (internal/process/next_tick.js:91:19)
  ...

Activity

  1. added
    netIssues and PRs related to the net subsystem.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    freebsdIssues and PRs related to the FreeBSD platform.
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Feb 8, 2018
  2. apapirovski commented on Feb 8, 2018

    @apapirovski
    Contributor

    Presumably it's hitting this path:

    node/lib/net.js

    Lines 975 to 985 in 6963a93

    if (err) {
    var sockname = self._getsockname();
    var details;
    if (sockname) {
    details = sockname.address + ':' + sockname.port;
    }
    const ex = exceptionWithHostPort(err, 'connect', address, port, details);
    self.destroy(ex);
    }

    Instead of the one it's supposed to (afterConnect).

    Anyone from @nodejs/http have any insights?

  3. apapirovski commented on Jun 7, 2018

    @apapirovski
    Contributor

    If I had to guess, this failure is related to the FreeBSD "jail" in our common file. It's failing before it even gets past the lookup which means it's failing on the IPv4 address. It's possible the process.env.LOCALHOST is set to something weird or something else strange happens? The fact that this only fails occasionally is rather confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.freebsdIssues and PRs related to the FreeBSD platform.netIssues and PRs related to the net subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions