Repository navigation
Build break in src/tracing/agent.h #18361
Description
- Version: master
- Platform: windows, linux
- Subsystem: tracing
It looks like #17489 and #18196 collided in master to break the build. The CurrentTimestampMicroseconds method was removed from the V8 type just as we took a dependency on it.
E:\GitHub\node\src\tracing/agent.h(15): error C3668: 'node::tracing::TracingController::CurrentTimestampMicroseconds': method with override specifier 'override' did not override any base class methods (compiling source file src\tracing\agent.cc) [E:\GitHub\node\node_lib.vcxproj]
Activity
kfarnung commentedon Jan 25, 2018
Looks like #18360 is open to resolve this.
apapirovski commentedon Jan 25, 2018
Fixed now that #18360 landed.