Repository navigation
Floating point value decoded incorrectly by buf.readDoubleBE() #18208
Description
Activity
/cc @bnoordhuis this is likely related to the recent switch to calculating this in JS.
Here's another example:
v9.4.0 (wrong):
> const x = Buffer.alloc(8,0) undefined > x.writeDoubleLE(41.0) 8 > x.toString('hex') '0000000000804440' > Buffer.from('0000000000804440','hex').readDoubleLE() 0v8.9.4 (correct):
> const x = Buffer.alloc(8,0) undefined > x.writeDoubleLE(41.0) 8 > x.toString('hex') '0000000000804440' > Buffer.from('0000000000804440','hex').readDoubleLE() 41edit: ok this seems to happen just because the
offsetargument here isundefinedand in previous versions it was coerced to 0, so passing in an explicit0will do.also, probably the confusion comes from the fact that the examples in the docs actually pass
undefinedthere (even ifoffsetisn't stated as optional): https://nodejs.org/api/buffer.html#buffer_buf_readdoublele_offset_noassert- added a commit that references this issue
on Jan 24, 2018 - added 2 commits that reference this issue
on Mar 6, 2018 - added a commit that references this issue
on May 8, 2018
example_js.txt
The attached example produces the output:
246800 encodes to 410e208000000000410e208000000000 decodes to 246800.03176522627The expected result is:
246800 encodes to 410e208000000000410e208000000000 decodes to 246800