Repository navigation
PSA: custom git command for landing PRs #18197
Description
Activity
Thanks! Does it include the checks from core-validate-commit?
@fhinkel "git node land --final" uses core-validate-commit so that has to be installed (still trying to figure out how to bundle it inside)
I think this is definitely worth a @nodejs/collaborators ping - would probably save quite some time :)
@fhinkel "git node land --final" uses core-validate-commit so that has to be installed (still trying to figure out how to bundle it inside)
Could we just make
core-validate-commita dependency ofnode-core-utils(and maybe also a part of the git repo)?Reacted by Tobias NießenVery neat tool. I had built my own PR lander tool (https://github.com/maclover7/committer-tools-rb), essentially does the same thing. Really happy to see we are working on automating away lots of stuff these days :)
This is great!
Would be good to document this in https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md I reckon?Reacted by Joyee Cheung and Benjamin Gruenbaumneat! good work!!
Great tool! I use it every time now :)
Should we close this issue or keep it open as a reminder to update the collaborator guide?
- added 2 commits that reference this issue
on Feb 26, 2018 - added a commit that references this issue
on May 8, 2018 - added a commit that references this issue
on Jul 27, 2026
node-core-utils v1.9.0 has been released with a custom git command called
git-node, which can fetch a PR, check its state, apply the patches, generate the necessary metadata, amend the commit message, and verify the commits.To land a PR with a single commit you can usually just go with pressing enter until it's complete. To land a PR with multiple commits you can use the command in conjunction with
git rebaseand friends.Watch the demos:
This has just gone out with little tests (WIP), although I have been using it from my branch for more than two months and it seems to be working pretty well. Would love to have some feedback and see how it works in the wild!