investigate flaky addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex #17849

Activity

1. Trott

   added

   flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.

   on Dec 24, 2017
2. maclover7

   added

   addonsIssues and PRs related to native addons.Issues and PRs related to native addons.

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   on Dec 25, 2017
3. bnoordhuis commented on Dec 25, 2017

   

   bnoordhuis

   on Dec 25, 2017

   Member

   More actions

   Signal 9 = SIGSEGV. If you can obtain a backtrace and a disassembly of the call site + info registers, I can probably figure out what the issue is.

   Educated guess: missing nullptr check somewhere.
4. apapirovski commented on Jan 3, 2018

   

   apapirovski

   on Jan 3, 2018

   Last edited by apapirovski

   Contributor

   More actions

   Given that this seems to be happening solely on Linux-based containers — is it possible this has to do with memory overcommitting? Signal 9 is SIGKILL, afaik, which would signal that the malloc test succeeds (due to overcommitting) but then the memory is not actually available when it tries to actually use it later on in the test.

   (SIGSEGV is 11, right?)
5. Trott commented on May 8, 2018

   

   Trott

   on May 8, 2018

   MemberAuthor

   More actions

   Might have a totally different cause then the Linux SIGSEGV (which I haven't seen in a while now), but it timed out on macOS today:

   https://ci.nodejs.org/job/node-test-commit-osx/18382/nodes=osx1010/console

   not ok 2007 addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex
     ---
     duration_ms: 120.392
     severity: fail
     exitcode: -15
     stack: |-
       timeout
     ...

   Host was test-requireio-osx1010-x64-1. Tests seem to run a significantly faster on the macstadium hosts. This one typically takes 4 seconds or so on macstadium but can take 10 or 50 seconds on requireio. If we're moving off of requireio, then we can probably ignore this timeout until we see it on macstadium. (Are we moving to exclusively using macstadium, @nodejs/build?)
6. apapirovski commented on Jun 1, 2018

   

   apapirovski

   on Jun 1, 2018

   Contributor

   More actions

   @nodejs/build Anyone want to investigate the memory overcommit suggestion and disable it on Alpine machines? It makes it impossible to detect available memory which tests like this one rely on.
7. Trott

   closed this as completedon Oct 18, 2018