Skip to content

CI status in PR differs from status in ci.nodejs.org #17387

Description

@vsemozhetbyt

#17345

PR status: All checks have passed. 13 successful checks

ci.nodejs.org status: one failure (centos6-64), one machine (freebsd10-64) still running (https://ci.nodejs.org/job/node-test-commit/14457/)

P.S. Now the status has suddenly turned into "1 pending and 12 successful checks".
P.P.S Now it is "All checks have passed. 13 successful checks" again, but we still have that one failure.

Activity

  1. added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Nov 29, 2017
  2. Fishrock123 commented on Nov 30, 2017

    @Fishrock123
    Contributor

    @vsemozhetbyt did you try hard reloading the page?

    Also I don't see CI status on any of that PR's commits?

  3. vsemozhetbyt commented on Nov 30, 2017

    @vsemozhetbyt
    ContributorAuthor

    @Fishrock123 Yes, I tried several times. Now, after landing and closing, the status is gone in the PR, but it was all green in the end (despite the last https://ci.nodejs.org/job/node-test-pull-request/11798/). Should I close this issue until something similar happens?

  4. refack commented on Nov 30, 2017

    @refack
    Contributor

    We still have a race problem with the status updates:

    1. One of the linux variants fail
    2. GitHub reports fail
    3. Another linux variant succeeds
    4. GitHub reports success

    /CC @maclover7 @gibfahn IMHO simplest fix is to report on completion of node-test-commit

  5. apapirovski commented on Apr 13, 2018

    @apapirovski
    Contributor

    @maclover7 @refack @gibfahn any news on this? Does it work as expected now or is there still a race condition?

  6. refack commented on Apr 13, 2018

    @refack
    Contributor

    node-test-commit does report it's status now so this can be closed
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions