Skip to content

Can we disable the C4251 build warning on Windows? #17286

Closed
Closed
Can we disable the C4251 build warning on Windows?#17286
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.duplicateIssues and PRs that are duplicates of other issues or PRs.windowsIssues and PRs related to the Windows platform.

Description

@targos
targos
opened on Nov 24, 2017

It generates a huge amount of output and comes mostly from V8.

/cc @nodejs/platform-windows

Edit: documentation: https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251
Edit 2: maybe I'm imagining it but it seems that the build is faster after disabling the warning...

Activity

  1. targos
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    windowsIssues and PRs related to the Windows platform.
    on Nov 24, 2017

  2. bnoordhuis commented on Nov 24, 2017

    @bnoordhuis
    bnoordhuis
    on Nov 24, 2017
    Member

    See discussion in #15570.

  3. targos commented on Nov 24, 2017

    @targos
    targos
    on Nov 24, 2017
    MemberAuthor

    Ah sorry, I forgot to search first. Closing in favor of #15570

  4. targos
    closed this as completedon Nov 24, 2017
  5. targos
    added
    duplicateIssues and PRs that are duplicates of other issues or PRs.
    on Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.duplicateIssues and PRs that are duplicates of other issues or PRs.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions