Repository navigation
source tarballs does not work without installing eslint #17098
Description
Activity
There are some different options to solve this:
- Make it install when
tools/eslintis not present - Make a special test rule for offline testing and skip doc/eslint tests
- Make it install when
Maybe introduce a
common.skipIfNoeslintfor the tests to skip iftools/eslintis not present?Maybe move eslint tests out of parallel and add
test-offlineto Makefile.@kasicka Well we do have test-internet though it's not normally run...
I write faster than I think.. still eslint tests should be moved out of
parallel/Thanks. Closing.
Since #16138 we started to test the eslint rules, which requires
tools/eslintto be present, but the eslint is not bundled inside the source tarballs and neither are there any rules in the makefile (or vcbuild.bat?) that try to install one, so those tests will always fail without manually running npm install first.