Skip to content

Add a new label fast-track?Β #16877

Description

@joyeecheung

We've decided in #16135 to fast-track certain types of PRs (mostly test-only and doc-only PRs), also we need to expedite some PR fixing regressions or CI from time to time as well, maybe we can just use a new label to make those decisions clearer? I am thinking about fast-track at the moment.

Refs: https://github.com/joyeecheung/node-core-utils/pull/92
Refs: https://github.com/joyeecheung/node-core-utils/pull/94

Activity

  1. added
    metaIssues and PRs related to the general management of the project.
    on Nov 8, 2017
  2. mhdawson commented on Nov 8, 2017

    @mhdawson
    Member

    Can you put together a couple of sentence description for what 'fast-track' would mean ? I'm wondering if it is meant to just be informational, a request to get agreement that a PR can be fast tracked or if its also a request to jump in and help get it reviewed/landed quickly ?

  3. joyeecheung commented on Nov 9, 2017

    @joyeecheung
    MemberAuthor

    @mhdawson

    I am leaning towrads "a request to get agreement that a PR can be fast tracked", meaning this should be landable after n approvals have been made (the number n needs discussion, of course). I will open a PR later to document this in the collaborator guide, that way it would be easier for us to discuss about the actual process (text changes).

  4. refack commented on Nov 10, 2017

    @refack
    Contributor

    I created the label. Without new wording in the collaborator guide, current policy is:

    Trivial changes (e.g. those which fix minor bugs or improve performance without affecting API or causing other wide-reaching impact), and focused changes that affect only documentation and/or the test suite, may be landed after a shorter delay if they have multiple approvals.

    So I would consider the use of this label as a declaration of intent so people can request to take it slow, and also for traceability of the decision process.

  5. maclover7 commented on Nov 26, 2017

    @maclover7
    Contributor

    @joyeecheung since the fast-track label has been created, this can be closed, right? (wasn't sure, wanted to double check)

  6. joyeecheung commented on Nov 27, 2017

    @joyeecheung
    MemberAuthor

    @maclover7 Yes, thanks for the reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    metaIssues and PRs related to the general management of the project.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions