Repository navigation
Please give the trailing slash back to os.tmpdir() #1669
Description
Activity
Why not use
path.join()or similarpathmethods?$ iojs > path.join('/oh/my/xxx/////', 'bar') '/oh/my/xxx/bar'If the string "/" comes from the user environment (though hardly possible), gets trimmed into "", what directory does it represent (and on what platform)?
That's true actually:
$ TEMP=/ ~/io.js/iojs -e 'console.log(JSON.stringify(require("os").tmpdir()))' ""
/should not be removed if it's the only character there.dirname works correctly in that case:
$ cat /test.js console.log(__dirname) $ ~/io.js/iojs /test.js /cc @tellnes
Perhaps semver-major changes aren't looked at hard enough... maybe we should introduce a hard minimum amount of reviewers for a major change, say 3.
We could change it so we remove all trailing slashes and keep one if there is no other characters there?
So remove trailing
path.septhen, but keep one if there is no other characters?- added a commit that references this issue
on May 13, 2015
Please revert the commit b57cc51
Since we can get any string (like "/oh/my/xxx/////"), from the environment, why bother to remove the trailing slash? For consistency between __dirname and os.tmpdir() #715 #747 ??