Coverage drop in nightly runs

Version: master
Platform: all
Subsystem: test

From the latest runs the c coverage has dropped 6.5%. Seems like it may be that the n-api tests are no longer running as one thing I noticed is that the coverage for node-api.cc was 0.

Quite likely related to 5be4dfa#diff-b67911656ef5d18c4ae36cb6741b7965

And this PR #15450

Looks like n-api addons may not be running in nightly builds either:

From https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1404-32/13016/console

The before/after is as follows and addons seems to be mentioned but I'm not sure if that includes the n-api versions.


After
/usr/bin/python tools/test.py -p tap --logfile test.tap --mode=release --flaky-tests=dontcare \
		 addons doctool message parallel pseudo-tty sequential

Before
/usr/bin/python tools/test.py -j 2 -p tap --logfile test.tap \
		--mode=release --flaky-tests=dontcare \
		 async-hooks default known_issues

@bcoe

Ping @bcoe

@BridgeAR

@BridgeAR thanks for looping in @bcoe I suspect he'll be able to quickly see if there is an issue in the change of if there is some update I need to make in the coverage job.

build: restore mistakenly dropped suites

Navigation Menu

Repository navigation

Coverage drop in nightly runs #16129

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Coverage drop in nightly runs #16129

Description

Activity

mhdawson commented on Oct 10, 2017

mhdawson commented on Oct 10, 2017

BridgeAR commented on Oct 10, 2017

mhdawson commented on Oct 10, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions