Skip to content

Reduce the numbers of iterations in benchmarkshttp/check_is_http_token #15218

Closed
Closed
Reduce the numbers of iterations in benchmarkshttp/check_is_http_token#15218
Labels
benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.httpIssues and PRs related to the http subsystem.questionIssues asking questions about Node.js.

Description

@mcollina
mcollina
opened on Sep 6, 2017
  • Version: master
  • Platform:
  • Subsystem: benchmarks

Currently benchmark/http/check_is_http_token takes several hours to complete if we try to compare two different Node versions. I think we should lower the number of iterations to simplify benchmarking the whole of http.

Specifically, I propose to revert this commit 39fdf07, or to reduce the number to something in between.
This was part of #6570.

@mscdex @nodejs/benchmarking what do you think?

Activity

  1. mscdex commented on Sep 6, 2017

    @mscdex
    mscdex
    on Sep 6, 2017
    Contributor

    To be honest, what the benchmarks in general could use is either some way to have specific n values for different mixes of inputs (would require some extra logic in each benchmark file) or we just switch to some sort of time-based mechanism for these synchronous benchmarks (would require some coordination with the benchmark runner).

  2. mscdex
    added
    benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.
    httpIssues and PRs related to the http subsystem.
    questionIssues asking questions about Node.js.
    on Sep 6, 2017

  3. bnoordhuis commented on Sep 21, 2017

    @bnoordhuis
    bnoordhuis
    on Sep 21, 2017
    Member

    @mcollina Ping. Do you want to follow up?

  4. mcollina commented on Sep 21, 2017

    @mcollina
    mcollina
    on Sep 21, 2017
    SponsorMemberAuthor

    I'm open to discuss this, but I do not see any actionable comment so far. What do we want to do?

  5. BridgeAR commented on Sep 21, 2017

    @BridgeAR
    BridgeAR
    on Sep 21, 2017
    Member

    This changed recently again in #14002. Closing this therefore.

  6. BridgeAR
    closed this as completedon Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.httpIssues and PRs related to the http subsystem.questionIssues asking questions about Node.js.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions