Skip to content

V8 tests failing  #14824

Closed
#14827
Closed
V8 tests failing #14824
#14827
Assignees
eugeneo
Labels
testIssues and PRs related to Node.js core tests and test infrastructure.v8 engineIssues and PRs related to the V8 dependency.

Description

@mhdawson
mhdawson
opened on Aug 14, 2017
  • Version: master
  • Platform: all
  • Subsystem: v8

Tests have been failing since Aug 12:

https://ci.nodejs.org/job/node-test-commit-v8-linux/

test/test/inspector/isolate-data.o
  CXX(target) /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/benchmark/v8test/v8test/deps/v8/out/x64.release/obj.target/inspector-test/test/inspector/task-runner.o
../test/inspector/inspector-test.cc:667:11: error: no member named 'FreeContext' in 'IsolateData'; did you mean 'FromContext'?
    data->FreeContext(context);
          ^~~~~~~~~~~
          FromContext
.././test/inspector/isolate-data.h:31:23: note: 'FromContext' declared here
  static IsolateData* FromContext(v8::Local<v8::Context> context);
                      ^
  CXX(target) /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/benchmark/v8test/v8test/deps/v8/out/x64.release/obj.target/mkgrokdump/test/mkgrokdump/mkgrokdump.o
  CXX(target) /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/benchmark/v8test/v8test/deps/v8/out/x64.release/obj.target/parser-shell/tools/parser-shell.o

Activity

  1. mhdawson commented on Aug 14, 2017

    @mhdawson
    mhdawson
    on Aug 14, 2017
    MemberAuthor

    Will try cleaning workspace as possibly its a stale test.

  2. mscdex
    added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    v8 engineIssues and PRs related to the V8 dependency.
    on Aug 14, 2017

  3. mhdawson commented on Aug 14, 2017

    @mhdawson
    mhdawson
    on Aug 14, 2017
    MemberAuthor

    CI run to see if workspace clean resolved the issue: https://ci.nodejs.org/job/node-test-commit-v8-linux/

  4. mhdawson commented on Aug 14, 2017

    @mhdawson
    mhdawson
    on Aug 14, 2017
    MemberAuthor

    CI re-runs failed so does not look like an issue with the environment.

    @jkrems failure seems to be related to this

    /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/benchmark/v8test/v8test/deps/v8/out/x64.release/obj.target/mkgrokdump/test/mkgrokdump/mkgrokdump.o
../test/inspector/inspector-test.cc

    which makes me guess it might be related to the inspector ?

    @nodejs/v8 FYI as well.

  5. hybrist commented on Aug 14, 2017

    @hybrist
    hybrist
    on Aug 14, 2017
    Contributor

    Guess some dependency was missed when cherry-picking this? 73c59bb

    /cc @eugeneo

  6. hybrist commented on Aug 14, 2017

    @hybrist
    hybrist
    on Aug 14, 2017
    Contributor

    Yeah, looks like the original commit contained the header change to add FreeContext to IsolateData (v8/v8@f19b889#diff-119937d090f8cb387f0b4d902c9e981fR71) but the cherry-pick does not contain it.

  7. eugeneo
    self-assigned this
    on Aug 14, 2017

  8. eugeneo commented on Aug 14, 2017

    @eugeneo
    eugeneo
    on Aug 14, 2017
    Contributor

    Looking into it.

  9. eugeneo
    closed this as completedin #14827on Aug 16, 2017
  10. MylesBorins
    added 2 commits that reference this issue on Sep 10, 2017

    deps: fix inspector v8 test

    7995897

    deps: fix inspector v8 test

    1a2f749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

testIssues and PRs related to Node.js core tests and test infrastructure.v8 engineIssues and PRs related to the V8 dependency.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions