Are asserts intentionally left compiled in? #14461

Activity

1. mscdex

   added

   c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.

   performanceIssues and PRs related to the performance of Node.js.Issues and PRs related to the performance of Node.js.

   questionIssues asking questions about Node.js.Issues asking questions about Node.js.

   buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.

   on Jul 24, 2017
2. bnoordhuis commented on Jul 25, 2017

   

   bnoordhuis

   on Jul 25, 2017

   Member

   More actions

   Yes, it's intentional; node has always been compiled with asserts enabled.

   In fact, we should probably just get rid of ASSERT and replace it with CHECK macros. I'll do that later today if I have time.
3. bnoordhuis

   added 2 commits that reference this issue on Jul 25, 2017

   src: replace ASSERT with CHECK

   ...

   dc9d2fc

   src: replace ASSERT with CHECK

   ...

   1b7372f
4. bnoordhuis

   closed this as completedin 1b7372fon Jul 27, 2017
5. addaleax

   added a commit that references this issue on Jul 27, 2017

   src: replace ASSERT with CHECK

   ...

   eb7faf6