Repository navigation
test: cctest flakiness on Windows - loops forever #14144
Copy link
Copy link
Closed
Labels
c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
Description
- Version:
master - Platform: Windows
- Subsystem: test,cctest
cctest can hang in an infinite loop. A few examples:
[ RUN ] EnvironmentTest.AtExitWithArgument
==== C stack trace ===============================
lh_node_usage_stats_bio [0x00007FF6CE172151+200673]
lh_node_usage_stats_bio [0x00007FF6CE16B8DD+173933]
lh_node_usage_stats_bio [0x00007FF6CE16B6BE+173390]
lh_node_usage_stats_bio [0x00007FF6CE16B8B3+173891]
lh_node_usage_stats_bio [0x00007FF6CE16B7B6+173638]
RtlProcessFlsData [0x00007FFF3790D9F7+295]
LdrShutdownThread [0x00007FFF3790BA49+73]
RtlExitUserThread [0x00007FFF379085DE+62]
FreeLibraryAndExitThread [0x00007FFF34DA2C7C+76]
FreeLibraryAndExitThread [0x00007FFF35369CDA+10]
lh_node_usage_stats_bio [0x00007FF6CE160B5D+129517]
lh_node_usage_stats_bio [0x00007FF6CE160CA5+129845]
lh_node_usage_stats_bio [0x00007FF6CE160AE0+129392]
BaseThreadInitThunk [0x00007FFF353613D2+34]
RtlUserThreadStart [0x00007FFF379054E4+52]
==== C stack trace ===============================
lh_node_usage_stats_bio [0x00007FF721840991+200801]
lh_node_usage_stats_bio [0x00007FF72183A11D+174061]
lh_node_usage_stats_bio [0x00007FF721839EFE+173518]
lh_node_usage_stats_bio [0x00007FF72183A0F3+174019]
lh_node_usage_stats_bio [0x00007FF721839FF6+173766]
RtlProcessFlsData [0x00007FFE06F5D9F7+295]
LdrShutdownThread [0x00007FFE06F5BA49+73]
RtlExitUserThread [0x00007FFE06F585DE+62]
FreeLibraryAndExitThread [0x00007FFE041E2C7C+76]
FreeLibraryAndExitThread [0x00007FFE05079CDA+10]
lh_node_usage_stats_bio [0x00007FF72182F39D+129645]
lh_node_usage_stats_bio [0x00007FF72182F4E5+129973]
lh_node_usage_stats_bio [0x00007FF72182F320+129520]
BaseThreadInitThunk [0x00007FFE050713D2+34]
RtlUserThreadStart [0x00007FFE06F554E4+52]
On 2017-06-09 - https://ci.nodejs.org/job/node-test-binary-windows/9117/RUN_SUBSET=0,VS_VERSION=vs2015,label=win2012r2/
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
Activity
refack commentedon Jul 9, 2017
/cc @nodejs/build @nodejs/testing @nodejs/platform-windows
BridgeAR commentedon Sep 28, 2017
@nodejs/build @nodejs/testing @nodejs/platform-windows PTAL
It would be great to get a green CI before the next Code & Learn.
joaocgreis commentedon Sep 28, 2017
I have checked the Jenkins logs in the CI machine a few times since, and I haven't seen this again. It's not impossible that I missed it, but it's unlikely. So, it is possible that this was already fixed by something else.
refack commentedon Sep 28, 2017
I havn't seen this recently either.
#14749 was a fix of a race condition that manifested in
cctestcrashing more frequently and duringAtExitWithArgument(mentioned in the above stack).It is very probable that was the root cause of this issue.
Closing as fixed by 97c4394...c80d400