Repository navigation
https: https.Server should be more careful with passed options #13584
Description
Activity
- changed the title
[-]https.Server should be more careful with passed options[/-][+]https: https.Server should be more careful with passed options[/+]on Jun 9, 2017 Did you mean
opts = opts || {};?Imo better to use default params.
Server(handler, opts={})@XadillaX As far as the second issue, you would have to make a copy (e.g. using
util._extend()like most other places in core) ofopts, provided it's an object. Otherwise use an empty object (or perhaps an object literal with the default properties/values already in place).- added a commit that references this issue
on Jun 10, 2017 - added a commit that references this issue
on Jun 14, 2017 - added a commit that references this issue
on Jun 29, 2017 - added a commit that references this issue
on Jul 11, 2017
Currently the
https.Serverconstructor has two issues:optsis truthy before trying to access properties on the valueoptsif certain properties on it are false-y