Skip to content

All versions of npm init hang on Node 8.1.0 #13557

Closed
Closed
All versions of npm init hang on Node 8.1.0#13557
Labels
confirmed-bugIssues and PRs for confirmed bugs.readlineIssues and PRs related to the built-in readline module.regressionIssues related to regressions.

Description

@iarna
iarna
opened on Jun 8, 2017
  • Version: 8.1.0
  • Platform: Darwin
  • Subsystem: Unsure

To reproduce, with Node 8.1.0 and any version of npm (we've explicitly tested w/ 2, 3, 4 & 5):

$ npm init
This utility will walk you through creating a package.json file.
It only covers the most common items, and tries to guess sensible defaults.

See `npm help json` for definitive documentation on these fields
and exactly what they do.

Use `npm install <pkg> --save` afterwards to install a package and
save it as a dependency in the package.json file.

Press ^C at any time to quit.
name: (x) 
version: (1.2.0)

At the prompt for version Node stops accepting input and doesn't respond to ^Z or ^C. (It does respond to kill -STOP and kill -INT. Continuing the process after a STOP results in keyboard input being echoed but the process still does not run.)

Activity

  1. addaleax
    added
    confirmed-bugIssues and PRs for confirmed bugs.
    on Jun 8, 2017

  2. krokofant commented on Jun 8, 2017

    @krokofant
    krokofant
    on Jun 8, 2017

    yarn behaves the same

  3. mscdex
    added
    v8.x
    on Jun 8, 2017

  4. addaleax commented on Jun 8, 2017

    @addaleax
    addaleax
    on Jun 8, 2017
    Member

    This was caused by 81ddeb9, /cc @gibfahn @jasnell

    @mscdex I’m removing the v8.x label because this is an issue on master as well.

  5. addaleax
    added
    readlineIssues and PRs related to the built-in readline module.
    and removed
    v8.x
    on Jun 8, 2017

  6. Fishrock123 commented on Jun 8, 2017

    @Fishrock123
    Fishrock123
    on Jun 8, 2017
    Contributor

    I can't seem to reproduce on master or 8.1.0?

    The WARN does seem to be on the wrong line though?

    Press ^C at any time to quit.
package name: (npm-test) npm WARN init canceled
🐟  ~/D/h/npm-test>

  7. Fishrock123 commented on Jun 8, 2017

    @Fishrock123
    Fishrock123
    on Jun 8, 2017
    Contributor

    I'd be curious to see what e.g. the following patch prints pre/post 81ddeb9

    diff --git a/lib/readline.js b/lib/readline.js
index 6a1ed150d7..6113846c91 100644
--- a/lib/readline.js
+++ b/lib/readline.js
@@ -1039,6 +1039,8 @@ function emitKeypressEvents(stream, iface) {
   } else {
     stream.on('newListener', onNewListener);
   }
+  iface.on('close', () => process._rawDebug('## CLOSE'))
+  stream.on('data', () => process._rawDebug('## DATA'))
   if (iface) {
     iface.once('close', () => { stream.removeListener('data', onData); });
   }

  8. addaleax commented on Jun 8, 2017

    @addaleax
    addaleax
    on Jun 8, 2017
    Member

    @Fishrock123 I’m not sure I’m reading your output correctly – you first have to enter the package name, only after that I can’t quite anymore.

  9. iarna commented on Jun 8, 2017

    @iarna
    iarna
    on Jun 8, 2017
    MemberAuthor

    @addaleax lol! I opened this issue and turned to @zkat and said "I bet Anna sees this and knows exactly the cause"

  10. Fishrock123 commented on Jun 8, 2017

    @Fishrock123
    Fishrock123
    on Jun 8, 2017
    Contributor

    Oops. 🙊

    It appears a close is emitted after pressing enter under normal circumstances...

    package name: (npm-test) ## DATA

## CLOSE
version: (0.0.0) ## DATA

description: ## DATA
npm WARN init canceled

  11. addaleax commented on Jun 8, 2017

    @addaleax
    addaleax
    on Jun 8, 2017
    Member

    @Fishrock123 Apparently, npm init (or rather the read module) creates a new readline instance per question that it asks…

    @jasnell You’re right, reverting is a bit silly, this is easy to fix (in a somewhat obvious way, in hindsight): okay, no, the original patch was incorrect and should be reverted.

    --- a/lib/readline.js
+++ b/lib/readline.js
@@ -1040,7 +1040,11 @@ function emitKeypressEvents(stream, iface) {
     stream.on('newListener', onNewListener);
   }
   if (iface) {
-    iface.once('close', () => { stream.removeListener('data', onData); });
+    iface.once('close', () => {
+      stream[KEYPRESS_DECODER] = null;
+      stream[ESCAPE_DECODER] = null;
+      stream.removeListener('data', onData);
+    });
   }
 }

    I’ll have a PR and tests up in a bit.

    @iarna Naaaaw! 💙

  12. Fishrock123 commented on Jun 8, 2017

    @Fishrock123
    Fishrock123
    on Jun 8, 2017
    Contributor

    Apparently, npm init (or rather the read module) creates a new readline instance per question that it asks…

    While that seems inefficient, readline does apparently emit close at the end of each line: https://nodejs.org/dist/latest-v8.x/docs/api/readline.html#readline_event_close

    (Which leads me to believe the patch above may be a bit inefficient too? We can discuss in a PR.)

  13. addaleax commented on Jun 8, 2017

    @addaleax
    addaleax
    on Jun 8, 2017
    Member

    While that seems inefficient, readline does apparently emit close at the end of each line: https://nodejs.org/dist/latest-v8.x/docs/api/readline.html#readline_event_close

    Are you sure? I don’t really read the docs as stating that…

  14. jasnell commented on Jun 8, 2017

    @jasnell
    jasnell
    on Jun 8, 2017
    Member

    That definitely seems like a bug then. It really should not be emitting close at that point. Let's see if we can fix that issue quickly before reverting the other commit

  15. addaleax commented on Jun 8, 2017

    @addaleax
    addaleax
    on Jun 8, 2017
    Member

    It really should not be emitting close at that point.

    It doesn’t, it’s the read module that closes the readline instance explicitly after having read the answer.

  16. addaleax commented on Jun 8, 2017

    @addaleax
    addaleax
    on Jun 8, 2017
    Member

    PR to fix/revert: #13560

  17. vsemozhetbyt
    added
    regressionIssues related to regressions.
    on Jun 8, 2017

  18. 131 commented on Jun 10, 2017

    @131
    131
    on Jun 10, 2017

    Following sample code is broken, waiting for you @addaleax !

    const readline = require('readline')

function prompt(opts, cb) {
  var input = process.stdin
  var output = process.stdout
  var terminal = !!(output.isTTY)
  var rlOpts = { input, output, terminal }
  var rl = readline.createInterface(rlOpts)
  rl.setPrompt(opts.prompt)
  rl.prompt()
  rl.on('line', function(line){
    rl.close()
    cb(null, line);
  })
}
const foo = function() {
  prompt( {prompt : "#>" }, function(err, line ){
    console.log("Got", err, line);
    foo();
  })
}

foo();

  19. gibfahn commented on Jun 10, 2017

    @gibfahn
    gibfahn
    on Jun 10, 2017
    Member

    @131 see #13560 (comment), it'll be fixed in the next v8.x release, scheduled for next Tuesday.

  20. addaleax
    closed this as completedin 871e4d0on Jun 10, 2017
  21. addaleax
    added a commit that references this issue on Jun 10, 2017

    test: add regression test for 13557

    2ea529b

  22. Bamieh commented on Jun 29, 2017

    @Bamieh
    Bamieh
    on Jun 29, 2017
    Contributor

    i'm still facing this issue guys

  23. addaleax commented on Jun 29, 2017

    @addaleax
    addaleax
    on Jun 29, 2017
    Member

    @Bamieh As described above, upgrade Node to the latest version and you will be fine.

  24. Bamieh commented on Jun 29, 2017

    @Bamieh
    Bamieh
    on Jun 29, 2017
    Contributor

    @addaleax true, it gets fixed when upgrading node, i only upgraded npm before and it didnt work. thanks

  25. gezquinndesign commented on Aug 1, 2018

    @gezquinndesign
    gezquinndesign
    on Aug 1, 2018

    This is still affecting the loopback-cli

    It freezes after giving the application name...

    node version - v10.7.0
    npm version=6.1.0
    loopback- 4.2.0
    OS- windows10

    anyone help please?

    Thanks

  26. sjarmak
    added a commit that references this issue on Jul 27, 2026

    test: add regression test for 13557

    871e4d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmed-bugIssues and PRs for confirmed bugs.readlineIssues and PRs related to the built-in readline module.regressionIssues related to regressions.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions