Release proposal: v1.6.4 #1340

Hmm, changelog maker is a little confused because the last tag is somehow on an orphaned commit.

npm@2.7.4 landed in the last release, 1.6.3.

Edit: fixed manually..

Update: Both #1337 and #1323 have landed.

@rvagg Should we make changelog-maker truncate names?

• [65d4d25f52] - build: default to armv7+vfpv3 for android (Giovanny Andres Gongora Granada) #1307

Also worth noting:

@iojs/collaborators please don't merge anything semver-minor until this goes out. :)

I will merge #1325 after releasing this.

@Fishrock123 I've just merge #1325. Please add them to the list.

@Fishrock123 can you do a git fetch origin to get the tag from the last release please, that should fix your commit list. I've been updating the original comment in each of these releases with a new commit list throughout the proposal period too fwiw.

And no, don't truncate names, that's a little disrespectful IMO

Next job: craft the changelog entry that goes above the commit list and iterate on it in here. I'm +1 on moving this out fairly quickly given that we have a decent sized list and the npm bugfix is worth getting in to people's hands.

Jeremiah Senkpiel can you do a git fetch origin to get the tag from the last release please, that should fix your commit list. I've been updating the original comment in each of these releases with a new commit list throughout the proposal period too fwiw.

Already done that once :)

@Fishrock123 do you have the latest changelog-maker? I'm constantly tweaking it to adapt to new conditions in the commit log in io.js. My commit list from changelog-maker --group:

• [3a69b7689b] - benchmark: add rsa/aes-gcm performance test (Shigeki Ohtsu) #1325
• [1c709f3aa9] - benchmark: add/remove hash algorithm (Shigeki Ohtsu) #1325
• [a081c7c522] - benchmark: fix chunky client benchmark execution (Brian White) #1257
• [65d4d25f52] - build: default to armv7+vfpv3 for android (Giovanny Andres Gongora Granada) #1307
• [6a134f7d70] - build: avoid passing private flags from pmake (Johan Bergström) #1334
• [5094a0fde3] - build: Pass BSDmakefile args to gmake (Johan Bergström) #1298
• [f782824d48] - deps: refactor openssl.gyp (Shigeki Ohtsu) #1325
• [21f4fb6215] - deps: update gyp to e1c8fcf7 (Shigeki Ohtsu) #1325
• [dac903f9b6] - deps: make node-gyp work with io.js (cjihrig) #990
• [5eb983e0b3] - deps: upgrade npm to 2.7.5 (Forrest L Norvell) #1337
• [008078862e] - deps: check in gtest, add util unit test (Ben Noordhuis) #1199
• [87053e8aee] - doc: add back quote to boolean variable 'true' (Kohei TAKATA) #1338
• [634e9629a0] - doc: add TC meeting minutes 2015-03-04 (Rod Vagg) #1123
• [245ba1d658] - doc: fix util.isObject documentation (Jeremiah Senkpiel) #1295
• [ad937752ee] - doc,src: remove references to --max-stack-size (Aria Stewart) #1327
• [15f058f609] - gyp: fix build with python 2.6 (Fedor Indutny) #1325
• [4dc6ae2181] - lib: remove unused variables (Brian White) #1290
• [b6e22c4bd5] - src: setup cluster workers before preloading (Ali Ijaz Sheikh) #1314
• [4a801c211c] - src: drop homegrown thread pool, use libplatform (Ben Noordhuis) #1329
• [f1e5a13516] - src: wrap MIN definition in infdef (Johan Bergström) #1322
• [6f72d87c27] - test: add test for a unref'ed timer leak (Fedor Indutny) #1330
• [416499c872] - timers: remove redundant code (Fedor Indutny) #1330
• [d22b2a934a] - timers: do not restart the interval after close (Fedor Indutny) #1330
• [cca5efb086] - timers: don't close interval timers when unrefd (Julien Gilli)
• [0e061975d7] - timers: fix unref() memory leak (Trevor Norris) #1330
• [eb459c8151] - tools: fix gyp to work on MacOSX without XCode (Shigeki Ohtsu) #1325
• [382bd9d2e0] - v8: back-port openbsd/amd64 build fix (Ben Noordhuis) #1318
• [efadffe861] - win,node-gyp: optionally allow node.exe/iojs.exe to be renamed (Bert Belder) #1266

oh sorry, I see that npm@2.7.4 commit isn't in your list now, must have fixed it on your end already

@rvagg I keep having to remove it by hand. The git is going to be weird until the next tag, apparently.

@Fishrock123 maybe git fetch origin; git checkout origin/v1.x; git branch -D v1.x; git checkout -b v1.x (I'm sure there's a shortcut for that!). This discrepancy is a concern, if there's something off with your commit log then you may not be releasing the same thing as the rest of us have.

Here's the git command it should be running to get the list:

git log --pretty=full --since="$(git show -s --format=%ad `git rev-list --max-count=1 --tags`)" --until="

It'll manually prune the two commits at the beginning from the last release.

I have an alias setup to do !git remote update -p; git merge --ff-only @{u}, has always worked fine before.. Hmmm

@rvagg that command stalls for me, but I got the one from the releases doc to work earlier. I thought we used changelog-maker for this..?

This is new on win2008r2.. windows config issue maybe?

=== release test-debug-port-from-cmdline ===
Path: parallel/test-debug-port-from-cmdline
c:\workspace\iojs+any-pr+multi\nodes\iojs-win2008r2\test\parallel\test-debug-port-from-cmdline.js:19
    process._debugProcess(child.pid);
            ^
Error: Access is denied.
    at Error (native)
    at ChildProcess.onChildMsg (c:\workspace\iojs+any-pr+multi\nodes\iojs-win2008r2\test\parallel\test-debug-port-from-cmdline.js:19:13)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:169:7)
    at handleMessage (child_process.js:306:10)
    at Pipe.channel.onread (child_process.js:334:11)
Command: c:\workspace\iojs+any-pr+multi\nodes\iojs-win2008r2\Release\iojs.exe c:\workspace\iojs+any-pr+multi\nodes\iojs-win2008r2\test\parallel\test-debug-port-from-cmdline.js

Building a nightly: https://jenkins-iojs.nodesource.com/job/iojs+release+nightly/126/

@Fishrock123 I've been putting deps at the bottom of the list of notable changes, and can I suggest you change the openssl one to be prefixed with **openssl**: rather than **deps**:, you could do the same for **Android**:, I've been doing this from a user-perspective while the commit messages are for internal consumption.

I think I've seen that win2008 failure before so I wouldn't let it hold you up. Here's another run I just did for another purpose where it's passed just fine: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/444/nodes=iojs-win2008r2/console

I've been putting deps at the bottom of the list of notable changes

Sure, but here they are the important bits..

**openssl** (..)

Yup, will do.

@rvagg how do you feel about this bit in particular, and in terms of removing #1075 from "known issues"?

timers: a minor memory leak when timers are unreferenced was fixed, alongside some related timers issues #1330 (Fedor Indutny). This appears to have fixed the remaining leak reported in #1075.

Can we perhaps get #1350 in (assuming others want it) so we don't grow the tarball for "no" reason?

@Fishrock123 yeah that timers bit sounds fine, I'd err on the side of caution and still report possible leak in Known issues _but_ it seems like we may be close enough to remove it so it's a judgement call for you to make since this is your release.

@jbergstroem there's enough LGTM's in there so it's up to @shigeki as to whether he can land it in time but I'd suggest that this release is ready to roll so could be pushed out right now so #1350 may have to wait till the next release.

(#1350 just landed)

Updated CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/446/
Updated Test Nightly: https://jenkins-iojs.nodesource.com/job/iojs+release+nightly/127/

I don't know if this is relevant but, node-gyp rebuild failed on my osx with v1.6.4 (I installed using nvm):

gyp ERR! stack Error: 404 status code downloading tarball

@gabeio it's not promoted yet, please stand by. (yay gpg subkey fun!)

ah ok sorry wasn't sure I just nvm installed and it pulled iojs-v1.6.4

Yeah, it (possibly erroneously) updates the /latest/ dist folder somewhat pre-emptively.

@gabeio It should work now. (note: armv6 takes much longer to build and will be uploaded later.)

yup thanks!

Whoops, thanks @silverwind!