Repository navigation
doc, test: question about test.py -v key in CONTRIBUTING.md #12771
Description
- Version: 8.0.0-rc.0
- Platform: Windows 7 x64
- Subsystem: test
CONTRIBUTING.md states:
If you are updating tests and just want to run a single test to check it, you can use this syntax to run it exactly as the test harness would:
$ python tools/test.py -v --mode=release parallel/test-stream2-transform
Is -v key intended here? I can't find this key in Makefile and vcbuild.bat. It seems it just adds more debug info:
j:\temp\node-master> python tools/test.py --mode=release parallel/test-stream2-transform
[00:00|% 100|+ 1|- 0]: Done
j:\temp\node-master> python tools/test.py -v --mode=release parallel/test-stream2-transform
# j:\temp\node-master\Release\node.exe -p process.arch
[00:00|% 0|+ 0|- 0]: release test-stream2-transform # j:\temp\node-master\Release\node.exe j:\temp\node-master\test\parallel\test-stream2-transform.js
[00:00|% 100|+ 1|- 0]: Done
Activity
gibfahn commentedon May 1, 2017
It should probably be removed to match Makefile#L198-199 exactly. The
-vwas originally added in 8a6c36d, and has never been in the Makefile AFAICT.gibfahn commentedon May 1, 2017
Might as well add the
-Joption while we're at it, as that's what the Makefile uses.vsemozhetbyt commentedon May 1, 2017
@gibfahn What these flags change, BTW?
gibfahn commentedon May 1, 2017
@vsemozhetbyt if you run
tools/test.py --helpit'll show you. You can also read the options in the source (e.g. here for-J.-j4means run 4 tests at a time (only does it for the parallel suite).-Jmeans calculate the number of cores and run that many tests at a time-vis verbose (as you mentioned)vsemozhetbyt commentedon May 1, 2017
@gibfahn Thank you!
richardlau commentedon May 2, 2017
It's extra characters to type though for no actual effect in the original use case (running a single test through the harness).
vsemozhetbyt commentedon May 2, 2017
@richardlau @gibfahn So maybe it is useful also to add an example how to run a test suite (section, folder).
gibfahn commentedon May 2, 2017
In the original case yes, but people won't be running the original case (and if they are they'll be copy-pasting right?) It's useful to know about
-Jbecause it makes the tests run faster, and also because it's possible the parallelism is triggering a bug in the test (which would be really hard to diagnose otherwise).Maybe, the problem with the test runner is that there are loads of options to go into. Maybe what we should do is note that you can do
tools/test.py --helpto see the available options, and then add some examples into that--helpsection (not sure how easy that is to do).vsemozhetbyt commentedon May 2, 2017
@gibfahn BTW: #12786
kysnm commentedon May 2, 2017
I would like to try this issue tonight or tomorrow, okay?
andreihincu commentedon May 3, 2017
hello.... I am kind of new here... I would like to help.
gibfahn commentedon May 8, 2017
@avhincu there's already a PR open for this (@kysnm has opened #12830). If you want to help there should be some other
good first contributionissues that haven't already been taken by someone, if you aren't finding any let us know and we'll find you one!gibfahn commentedon May 18, 2017
#12830 landed.