Skip to content

test: fix/rename test/debugger/helper-debugger-* #12742

Description

@refack
  • Version: master
  • Subsystem: test

tests for line debugger should use inspect protocol and CLI args

Tracking:

  • test/debugger/test-debugger-repl-break-in-module.js
  • test/debugger/test-debugger-repl-restart.js
  • test/debugger/test-debugger-repl-term.js
  • test/debugger/test-debugger-repl-utf8.js
  • test/debugger/helper-debugger-repl.js
  • test/debugger/test-debugger-repl.js

Activity

  1. added
    inspectorIssues and PRs related to the V8 inspector protocol.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Apr 29, 2017
  2. Trott commented on May 27, 2017

    @Trott
    Member

    These tests aren't run in CI or via make test/vcbuild test. They should probably be moved one-by-one to parallel or sequential if they work there, and ones that are truly debugger-specific should be removed. They have a very checkered history in terms of reliability.

  3. self-assigned this
    on May 27, 2017
  4. added
    good first issueIssues that are suitable for first-time contributors.
    on May 28, 2017
  5. refack commented on May 28, 2017

    @refack
    ContributorAuthor

    To follow up on @Trott suggestion I've made a tracking list. Marking as good-first-contribution but I assume contributors will need mentoring. I'll be happy to help.

  6. rhoboat commented on May 28, 2017

    @rhoboat

    dibs

  7. removed
    good first issueIssues that are suitable for first-time contributors.
    on May 28, 2017
  8. refack commented on May 28, 2017

    @refack
    ContributorAuthor

    @archanid as I said, hopefully it's well defined, but it might require some trial and error. If you need any help feel free to ping me.

  9. assigned and unassigned on May 28, 2017
  10. added
    wipIssues and PRs that are still a work in progress.
    on Jun 15, 2017
  11. maclover7 commented on Oct 14, 2017

    @maclover7
    Contributor

    @refack @Trott should this be closed since #15139 was merged / test/debugger has been deleted?

  12. removed
    wipIssues and PRs that are still a work in progress.
    on Oct 14, 2017
  13. refack commented on Oct 14, 2017

    @refack
    ContributorAuthor

    @archanid I'm closing this. If by any chance you found some good nuggets in that directory, feel free to PR them back.

  14. removed their assignment
    on Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    inspectorIssues and PRs related to the V8 inspector protocol.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions