Skip to content

The inspector process.on(SIGPROF) warning is non-standard.Β #12706

Description

@Fishrock123
  • Version: master (as of yesterday?)
  • Platform: macOS
  • Subsystem: src

An internal project is generating this warning when run:

process.on(SIGPROF) is reserved while debugging

It was not immediately clear to me that this was indeed from node, since no (node:pid) prefix was attached.

The warning is emitted from here and was added in 84ad31f about a year ago (though I'm not sure inspector was on by default then). My understanding is that this warning does not happen for us on LTS versions of Node.

Edit: We are not launching the inspector in any way when running into this.

Activity

  1. added
    c++Issues and PRs that require attention from people who are familiar with C++.
    inspectorIssues and PRs related to the V8 inspector protocol.
    lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.
    on Apr 27, 2017
  2. Fishrock123 commented on Apr 27, 2017

    @Fishrock123
    ContributorAuthor

    --trace-warnings also does not work to find where this warning is originating from, although I suspect it was from one of those "ensure this callback is run on any exit" modules.

  3. cjihrig commented on Apr 27, 2017

    @cjihrig
    Contributor

    I don't think it shows up as an official warning because it's just a print statement. I think it would have to use ProcessEmitWarning().

  4. Fishrock123 commented on Jun 15, 2017

    @Fishrock123
    ContributorAuthor

    Refs: #12709 (the above commit(s))

  5. Trott commented on Apr 30, 2018

    @Trott
    Member

    What should we do about this? Nothing? Change it to emit a warning? Something else?

  6. cjihrig commented on May 5, 2018

    @cjihrig
    Contributor

    This is a proper warning since #12709. The only question is whether or not the inspector should reserve SIGPROF, even when it's not in use. This check is always true if the inspector is started, which is different from active (HasConnectedSessions()).

  7. jasnell commented on Aug 11, 2018

    @jasnell
    Member

    Given that it's now a proper warning, I think we should close this issue. Whether inspector should reserve SIGPROF is a separate concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c++Issues and PRs that require attention from people who are familiar with C++.inspectorIssues and PRs related to the V8 inspector protocol.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions