The inspector process.on(SIGPROF) warning is non-standard.Β #12706
Description
Activity
- addedc++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.inspectorIssues and PRs related to the V8 inspector protocol.Issues and PRs related to the V8 inspector protocol.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.Issues and PRs involving general changes in the lib/ or src/ directories.
on Apr 27, 2017 --trace-warningsalso does not work to find where this warning is originating from, although I suspect it was from one of those "ensure this callback is run on any exit" modules.I don't think it shows up as an official warning because it's just a print statement. I think it would have to use
ProcessEmitWarning().- added a commit that references this issue
on May 11, 2017 - added a commit that references this issue
on May 19, 2017 Refs: #12709 (the above commit(s))
What should we do about this? Nothing? Change it to emit a warning? Something else?
This is a proper warning since #12709. The only question is whether or not the inspector should reserve
SIGPROF, even when it's not in use. This check is alwaystrueif the inspector is started, which is different from active (HasConnectedSessions()).Given that it's now a proper warning, I think we should close this issue. Whether inspector should reserve SIGPROF is a separate concern.
An internal project is generating this warning when run:
It was not immediately clear to me that this was indeed from node, since no
(node:pid)prefix was attached.The warning is emitted from here and was added in 84ad31f about a year ago (though I'm not sure inspector was on by default then). My understanding is that this warning does not happen for us on LTS versions of Node.
Edit: We are not launching the inspector in any way when running into this.