Skip to content

test: simple/test-fs-symlink-dir-junction-relative broken on linux #126

Description

@bnoordhuis
$ out/x64.release/node test/simple/test-fs-symlink-dir-junction-relative.js
linkData: /home/bnoordhuis/src/v0.12/test/fixtures/cycles
linkPath: /home/bnoordhuis/src/v0.12/test/tmp/cycles_link
relative target: ../fixtures/cycles

assert.js:100
  throw new assert.AssertionError({
        ^
AssertionError: "/home/bnoordhuis/src/fixtures/cycles" == "/home/bnoordhuis/src/v0.12/test/fixtures/cycles"
    at /home/bnoordhuis/src/v0.12/test/simple/test-fs-symlink-dir-junction-relative.js:54:14
    at Object.oncomplete (fs.js:95:15)

Reverting 7014b7c makes no difference. /cc @piscisaureus

Activity

  1. piscisaureus commented on Dec 9, 2014

    @piscisaureus
    Contributor

    @bnoordhuis I think the test is supposed to be ran from the "simple" directory

  2. bnoordhuis commented on Dec 9, 2014

    @bnoordhuis
    MemberAuthor

    It's also broken when run through the test runner:

    $ python tools/test.py --arch=x64 --mode=release simple/test-fs-symlink-dir-junction-relative
    === release test-fs-symlink-dir-junction-relative ===                    
    Path: simple/test-fs-symlink-dir-junction-relative
    linkData: /home/bnoordhuis/src/v0.12/test/fixtures/cycles
    linkPath: /home/bnoordhuis/src/v0.12/test/tmp/cycles_link
    relative target: ../fixtures/cycles
    assert.js:100
      throw new assert.AssertionError({
            ^
    AssertionError: "/home/bnoordhuis/src/fixtures/cycles" == "/home/bnoordhuis/src/v0.12/test/fixtures/cycles"
        at /home/bnoordhuis/src/v0.12/test/simple/test-fs-symlink-dir-junction-relative.js:54:14
        at Object.oncomplete (fs.js:95:15)
    Command: out/x64.release/node /home/bnoordhuis/src/v0.12/test/simple/test-fs-symlink-dir-junction-relative.js
    [00:00|% 100|+   0|-   1]: Done                                         
    
  3. piscisaureus commented on Dec 9, 2014

    @piscisaureus
    Contributor

    Fixed in 4efc02a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmed-bugIssues and PRs for confirmed bugs.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions