Skip to content

tools: question about some ESLint config options #12566

Closed
Closed
tools: question about some ESLint config options#12566
Labels
questionIssues asking questions about Node.js.toolsIssues and PRs related to the tools directory.

Description

@vsemozhetbyt
vsemozhetbyt
opened on Apr 21, 2017
  • Subsystem: tools

  1. Is it worth to set the option parserOptions.sourceType as module in the lib/.eslintrc.yaml? What are pros / cons / breaking changes?

  2. Why don't we use the option root as true in the main .eslintrc.yaml ?

    By default, ESLint will look for configuration files in all parent folders up to the root directory. This can be useful if you want all of your projects to follow a certain convention, but can sometimes lead to unexpected results. To limit ESLint to a specific project, place "root": true inside the eslintConfig field of the package.json file or in the .eslintrc.* file at your project’s root level. ESLint will stop looking in parent folders once it finds a configuration with "root": true.

    Would it spare the linter some fs churn / time?

cc @not-an-aardvark, @silverwind, @Trott

Activity

  1. vsemozhetbyt
    added
    questionIssues asking questions about Node.js.
    toolsIssues and PRs related to the tools directory.
    on Apr 21, 2017

  2. gibfahn commented on Apr 21, 2017

    @gibfahn
    gibfahn
    on Apr 21, 2017
    Member

    2. makes sense to me.

  3. vsemozhetbyt commented on Apr 21, 2017

    @vsemozhetbyt
    vsemozhetbyt
    on Apr 21, 2017
    ContributorAuthor

    @gibfahn I think it can even prevent some murky bugs: if somebody forgetfully leaves some .eslintrc config in a parent directory above node repo directory, some node rules can be overwritten.

  4. silverwind commented on Apr 21, 2017

    @silverwind
    silverwind
    on Apr 21, 2017
    Contributor
    1. there's two issues that come with that option:
    • eslint complains about unneccessary 'use strict'; statements
    • eslint also complains about return in the top scope

    why do you want to enable it? We don't have any module files yet, do we?

    1. sounds like a good addition.

  5. vsemozhetbyt commented on Apr 21, 2017

    @vsemozhetbyt
    vsemozhetbyt
    on Apr 21, 2017
    ContributorAuthor

    @silverwind

    1. Oh, it seems I've misunderstood the option. It means ES6 modules, right?
    2. should it be:
    root: true

    at the top of the main .eslintrc.yaml?

  6. silverwind commented on Apr 21, 2017

    @silverwind
    silverwind
    on Apr 21, 2017
    Contributor
    1. yes, it means import/export syntax
    2. yeah

  7. Fishrock123 commented on Apr 21, 2017

    @Fishrock123
    Fishrock123
    on Apr 21, 2017
    Contributor

    Is it worth to set the option parserOptions.sourceType as module in the lib/.eslintrc.yaml?

    No. That would be incorrect as those rules are for ES Modules, e.g. no top-level return as silverwind mentioned.

  8. jasnell
    added a commit that references this issue on Apr 24, 2017

    tools: add `root: true` in main .eslintrc.yaml

    bf14dbe
  9. jasnell
    closed this as completedin bf14dbeon Apr 24, 2017
  10. evanlucas
    added 4 commits that reference this issue on Apr 25, 2017

    tools: add `root: true` in main .eslintrc.yaml

    ee02ea2

    tools: add `root: true` in main .eslintrc.yaml

    133c925

    tools: add `root: true` in main .eslintrc.yaml

    200e899
  11. gibfahn
    added a commit that references this issue on May 16, 2017

    tools: add `root: true` in main .eslintrc.yaml

    3dad38e
  12. MylesBorins
    added a commit that references this issue on May 18, 2017

    tools: add `root: true` in main .eslintrc.yaml

    fd126b5
  13. andrew749
    added a commit that references this issue on Jul 19, 2017

    tools: add `root: true` in main .eslintrc.yaml

    8d61dfd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionIssues asking questions about Node.js.toolsIssues and PRs related to the tools directory.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions