doc: typo in api/process.md

Version: master, v7.x, v6.x
Platform: n/a
Subsystem: doc

In doc/api/process.md, there is a typo in the 'A note on process I/O' section where it says:

Synchronous writes avoid problems such as output written with `console.log()` or `console.write()` being unexpectedly interleaved, ...

where console.write() should presumably instead be console.error(), since console.write() does not exist and console.error() is the only other console method referred to in that section.

I can make this change.

I have this ready but it's blocked by another PR :-(. Once that one clears I can send this one.

@morrme

@morrme what do you mean by blocked? You can have lots of PRs open at the same time.

I see that your issue12565 branch also has the commits from your doc-ci-jobs branch. The fix is to do:

git fetch --all # Make sure you have the latest changes
git checkout issue12565
git push # Make sure your remote branches are up to date
git reset --hard upstream/master # Assumes nodejs/node remote is called upstream
git cherry-pick origin/issue12565 # Assumes morrme/node remote is called origin
git push --force-with-lease

The cherry-pick will just pull the top commit from your remote branch, which is the only one you want.

Then you can raise another Pull Request with: master...morrme:issue12565

@gibfahn

@gibfahn that's what' I meant. I am so embarrassed to have made such a mistake!

I found a similar fix but we've gotten so far with the CI jobs issue, I was worried about messing it up.

I will give it a try.

Thanks for your support, as always!

I'm so embarrassed to have made such a mistake!

Git is hard, no need to be embarassed 😁 .

After the cherry-pick you can do git log --graph --decorate --oneline, you should see something like this (your branch is master + the doc commit):

I found a similar fix but we've gotten so far with the CI jobs issue, I was worried about messing it up.

That's a very reasonable thing to worry about. The trick is to run git status before you make changes (make sure you're on the right branch), and to triple-check before your force push (git push -f).

@gibfahn

THANK YOU @gibfahn ! 🏆

doc: fix typo in doc/api/process.md

Navigation Menu

Repository navigation

doc: typo in api/process.md #12565

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

doc: typo in api/process.md #12565

Description

Activity

morrme commented on Apr 21, 2017

morrme commented on Apr 22, 2017

gibfahn commented on Apr 23, 2017

morrme commented on Apr 23, 2017

gibfahn commented on Apr 23, 2017

morrme commented on Apr 23, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions