new lint option on windows is missing documentation #11971

Activity

1. refack

   changed the title [-]no lint option, missing documentation[/-] [+]new lint option on windows is missing documentation[/+] on Mar 21, 2017
2. gibfahn

   added

   good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.

   on Mar 21, 2017
3. gibfahn commented on Mar 21, 2017

   

   gibfahn

   on Mar 21, 2017

   Last edited by gibfahn

   Member

   More actions

   This seems like a good first contribution for someone (@refack if you want to fix it yourself feel free).
4. refack commented on Mar 21, 2017

   

   refack

   on Mar 21, 2017

   Last edited by refack

   ContributorAuthor

   More actions

   Not first! 😛
5. gibfahn commented on Mar 21, 2017

   

   gibfahn

   on Mar 21, 2017

   Last edited by gibfahn

   Member

   More actions

   Not first!

   @refack not sure what you mean. If you're intending to fix it yourself then go for it, I assumed you weren't planning to, normally people don't bother to raise an Issue first if it's a simple PR.
6. refack commented on Mar 21, 2017

   

   refack

   on Mar 21, 2017 via email

   ContributorAuthor

   More actions

   I might, but why do you assume it'll be my first contribution 😉 Also I believe even a post-mortem code review helps the original author...

   …

   On Tue, Mar 21, 2017 at 1:40 PM, Gibson Fahnestock ***@***.*** > wrote: Not first! @refack <https://github.com/refack> not sure what you mean. If you're intending to fix it yourself then go for it, I assumed you weren't planning to, as normally people don't bother to raise Issues if it's a simple PR. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11971 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAF6s0wHzxgR0RAFNHfrhnNvAgF_j4-Oks5roAt9gaJpZM4MkILV> .
7. refack commented on Mar 21, 2017

   

   refack

   on Mar 21, 2017

   ContributorAuthor

   More actions

   Ohh, did you mean you wanted to? Sorry 😬. Go ahead! I'm working on something else...
8. gibfahn commented on Mar 21, 2017

   

   gibfahn

   on Mar 21, 2017

   Last edited by gibfahn

   Member

   More actions

   @refack good-first-contribution means that this would be a good first contribution for someone who hasn't contributed to node before, not that it is or has to be your first contribution. If someone wants to have a go, then the label means anyone can go ahead ahead and raise a PR. Having some easy issues with that label helps new contributors get started.

   I assumed you weren't planning to raise a PR yourself, so added the tag to open it up to anybody. If you're going to fix it then great, please do!

   Also I believe even a post-mortem code review helps the original author...

   Agreed, not saying you shouldn't raise an issue, just that most people wouldn't bother.

   And yeah, I'm following the node-gyp repo, I'm aware that this isn't your first contribution 😄

   😄React with 😄1Reacted by Refael Ackermann
9. Fishrock123

   added

   docIssues and PRs related to Node.js documentation.Issues and PRs related to Node.js documentation.

   on Mar 22, 2017
10. brennemo commented on Mar 22, 2017

    

    brennemo

    on Mar 22, 2017

    Contributor

    More actions

    I'll give this a go as a first contribution.

    👍React with 👍1Reacted by Gibson Fahnestock
11. brennemo

    added 6 commits that reference this issue on Mar 22, 2017

    Adds options for cpp linting to help section of Windows build script

    ...

    ab470d6

    build: add lint option to vcbuild.bat help

    ...

    73b0204

    build: add lint option to vcbuild.bat help

    ...

    e52cb17
12. jasnell

    closed this as completedin a8a042aon Mar 24, 2017
13. MylesBorins

    added a commit that references this issue on Mar 28, 2017

    build: add lint option to vcbuild.bat help

    ...

    fb41ee3
14. refack

    added a commit that references this issue on Aug 22, 2017

    build: add lint option to vcbuild.bat help

    ...

    180bec1
15. MylesBorins

    added a commit that references this issue on Sep 19, 2017

    build: add lint option to vcbuild.bat help

    ...

    c9ae894
16. sjarmak

    added a commit that references this issue on Jul 27, 2026

    build: add lint option to vcbuild.bat help

    ...

    a8a042a