Skip to content

vm benchmarks are broken #11895

Closed
Closed
vm benchmarks are broken#11895
Labels
benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.good first issueIssues that are suitable for first-time contributors.

Description

@targos
targos
opened on Mar 17, 2017

In #9615 common.v8ForceOptimization was removed along with most of the calls to it.
The vm benchmarks were added after the creation of the PR and they were forgotten.

Activity

  1. targos
    added
    benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.
    good first issueIssues that are suitable for first-time contributors.
    on Mar 17, 2017

  2. TimothyGu commented on Mar 17, 2017

    @TimothyGu
    TimothyGu
    on Mar 17, 2017
    Member

    Also applies to url/whatwg-url-idna.js

  3. lucaslago
    added a commit that references this issue on Mar 17, 2017

    benchmark: remove v8ForceOptimization calls

    cda921e
  4. targos
    added a commit that references this issue on Mar 21, 2017

    benchmark: remove v8ForceOptimization calls

    3129ba2

  5. targos commented on Mar 21, 2017

    @targos
    targos
    on Mar 21, 2017
    MemberAuthor

    Fixed in 3129ba2

  6. targos
    closed this as completedon Mar 21, 2017
  7. jungx098
    added a commit that references this issue on Mar 21, 2017

    benchmark: remove v8ForceOptimization calls

    4bff6b8
  8. MylesBorins
    added a commit that references this issue on Mar 28, 2017

    benchmark: remove v8ForceOptimization calls

    85eb1bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.good first issueIssues that are suitable for first-time contributors.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions